Skip to content

Fix: Strip None values from orthology mapping API response #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Swargambharath987 wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix: Strip None values from orthology mapping API response #1207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions www/api/resources/orthologs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def normalize_gene(gene):
return {"error": str(e)}, 400

# Filter out genes that are not in the dataset
normalized_mapped_genes = [normalize_gene(mapped_gene_symbol) for mapped_gene_symbol in mapped_gene_symbols if check_gene_in_dataset(gene_map, mapped_gene_symbol)]
normalized_mapped_genes = [g for mapped_gene_symbol in mapped_gene_symbols if check_gene_in_dataset(gene_map, mapped_gene_symbol) if (g := normalize_gene(mapped_gene_symbol)) is not None]
mapped_gene_symbols_dict[gene_symbol] = normalized_mapped_genes

# last chance to map. Check if nonmapping genes are actually in the dataset (since gene_organism_id may not have been provided)
Expand Down Expand Up @@ -352,7 +352,7 @@ def normalize_gene(gene):

# for each mapped gene symbol, verify the mapped genes are in the dataset and normalize to those genes
for gene_symbol in gene_symbols:
normalized_mapped_genes = [normalize_gene(mapped_gene_symbol) for mapped_gene_symbol in mapped_gene_symbols_dict[gene_symbol] if check_gene_in_dataset(gene_map, mapped_gene_symbol)]
normalized_mapped_genes = [g for mapped_gene_symbol in mapped_gene_symbols_dict[gene_symbol] if check_gene_in_dataset(gene_map, mapped_gene_symbol) if (g := normalize_gene(mapped_gene_symbol)) is not None]

if not normalized_mapped_genes:
genes_not_mapped.append(gene_symbol)
Expand Down