Skip to content

Conversation

@hughperkins
Copy link
Collaborator

@hughperkins hughperkins commented Jan 6, 2026

No description provided.

@hughperkins hughperkins marked this pull request as ready for review January 7, 2026 00:15
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🔴 Benchmark Regression Detected ➡️ Report

Comment on lines -73 to -74
pip install --no-input --upgrade pip pkg-info wheel
pip install --no-input --ignore-installed --upgrade blinker pyparsing setuptools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commands are missing in the setup script. They should be added back.

@hughperkins
Copy link
Collaborator Author

hughperkins commented Jan 7, 2026 via email

@hughperkins
Copy link
Collaborator Author

hughperkins commented Jan 7, 2026 via email

@hughperkins
Copy link
Collaborator Author

hughperkins commented Jan 7, 2026 via email

@duburcqa
Copy link
Collaborator

duburcqa commented Jan 7, 2026

The difference is that for uv, we dont have conflicts with system installed
packages.

Yes, we do not want to rely on system dependencies.

@duburcqa
Copy link
Collaborator

duburcqa commented Jan 7, 2026

Still, it is important to make sure the latest versions of pip wheel setuptools are installed on the system to avoid build failure when building packages from source. It is just being extra cautious but I don't want to hit hard-to-debug pip install failures.

@duburcqa duburcqa changed the title [MISC] Migrate unit tests to uv [MISC] Migrate unit tests to uv. Jan 8, 2026
@duburcqa duburcqa changed the title [MISC] Migrate unit tests to uv. [MISC] Migrate from pip to uv for unit tests venv in production CI. Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🔴 Benchmark Regression Detected ➡️ Report

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🔴 Benchmark Regression Detected ➡️ Report

duburcqa
duburcqa previously approved these changes Jan 8, 2026
@duburcqa
Copy link
Collaborator

duburcqa commented Jan 8, 2026

Blocked by #2208

@hughperkins
Copy link
Collaborator Author

Thanks! 🙌

@duburcqa duburcqa merged commit 8c2ff73 into Genesis-Embodied-AI:main Jan 9, 2026
20 checks passed
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

⚠️ Abnormal Benchmark Result Detected ➡️ Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants