-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[MISC] Migrate from pip to uv for unit tests venv in production CI. #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Migrate from pip to uv for unit tests venv in production CI. #2195
Conversation
|
🔴 Benchmark Regression Detected ➡️ Report |
| pip install --no-input --upgrade pip pkg-info wheel | ||
| pip install --no-input --ignore-installed --upgrade blinker pyparsing setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands are missing in the setup script. They should be added back.
|
Not needed with uv
…On Wed, Jan 7, 2026 at 3:50 AM Alexis DUBURCQ ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/production.yml
<#2195 (comment)>
:
> - pip install --no-input --upgrade pip pkg-info wheel
- pip install --no-input --ignore-installed --upgrade blinker pyparsing setuptools
This commands are missing in the setup script. They should be added back.
—
Reply to this email directly, view it on GitHub
<#2195 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6FKEMI3MCF36MMEYEP6L4FTCF7AVCNFSM6AAAAACQ4GRNXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMZTHA4TCNJZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I found them necessary in my pip workflow, but not in the uv workflow.
The pip version:
https://github.com/hughperkins/Genesis/blob/a6f8559fe3aaf8b7fbe78dd21c7580e774c5291d/.github/workflows/scripts/production_build.sh#L30
On Wed, Jan 7, 2026 at 5:49 AM Hugh Perkins ***@***.***>
wrote:
… Not needed with uv
On Wed, Jan 7, 2026 at 3:50 AM Alexis DUBURCQ ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In .github/workflows/production.yml
> <#2195 (comment)>
> :
>
> > - pip install --no-input --upgrade pip pkg-info wheel
> - pip install --no-input --ignore-installed --upgrade blinker pyparsing setuptools
>
> This commands are missing in the setup script. They should be added back.
>
> —
> Reply to this email directly, view it on GitHub
> <#2195 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA6FKEMI3MCF36MMEYEP6L4FTCF7AVCNFSM6AAAAACQ4GRNXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMZTHA4TCNJZGQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
The difference is that for uv, we dont have conflicts with system installed
packages.
On Wed, Jan 7, 2026 at 5:51 AM Hugh Perkins ***@***.***>
wrote:
… I found them necessary in my pip workflow, but not in the uv workflow.
The pip version:
https://github.com/hughperkins/Genesis/blob/a6f8559fe3aaf8b7fbe78dd21c7580e774c5291d/.github/workflows/scripts/production_build.sh#L30
On Wed, Jan 7, 2026 at 5:49 AM Hugh Perkins ***@***.***>
wrote:
> Not needed with uv
>
> On Wed, Jan 7, 2026 at 3:50 AM Alexis DUBURCQ ***@***.***>
> wrote:
>
>> ***@***.**** commented on this pull request.
>> ------------------------------
>>
>> In .github/workflows/production.yml
>> <#2195 (comment)>
>> :
>>
>> > - pip install --no-input --upgrade pip pkg-info wheel
>> - pip install --no-input --ignore-installed --upgrade blinker pyparsing setuptools
>>
>> This commands are missing in the setup script. They should be added back.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#2195 (review)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AAA6FKEMI3MCF36MMEYEP6L4FTCF7AVCNFSM6AAAAACQ4GRNXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMZTHA4TCNJZGQ>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Yes, we do not want to rely on system dependencies. |
|
Still, it is important to make sure the latest versions of |
|
🔴 Benchmark Regression Detected ➡️ Report |
|
🔴 Benchmark Regression Detected ➡️ Report |
|
Blocked by #2208 |
|
Thanks! 🙌 |
|
|
No description provided.