Skip to content

Conversation

@hughperkins
Copy link
Collaborator

Description

  • added unit test to check that planes do not have mass EPS
  • added fix so that planes no longer have EPS mass

Notes:

  1. test:
    • PASSes on this PR
    • PASSes on v0.3.11
    • FAILs on main
  2. heavily cursored...

to test:

pytest -svx -n 0 tests/test_plane_mass.py

Related Issue

Resolves Genesis-Embodied-AI/Genesis#

Motivation and Context

How Has This Been / Can This Be Tested?

Screenshots (if appropriate):

This branch:

Screenshot 2026-01-06 at 15 59 00

main:

Screenshot 2026-01-06 at 15 59 06

Checklist:

  • I read the CONTRIBUTING document.
  • I followed the Submitting Code Changes section of CONTRIBUTING document.
  • I tagged the title correctly (including BUG FIX/FEATURE/MISC/BREAKING)
  • I updated the documentation accordingly or no change is needed.
  • I tested my changes and added instructions on how to test it for reviewers.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@duburcqa
Copy link
Collaborator

duburcqa commented Jan 6, 2026

Bug fixes should be physically motivated. Your unit test is checking that your implementation is correct, but not that it makes any physical sense. By the way, the mass of objects that are fixed wrt the world is undefined in essence, so computing it asking for it should rather raise an exception.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

🔴 Benchmark Regression Detected ➡️ Report

@hughperkins hughperkins closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants