Skip to content

Conversation

@stxue1
Copy link
Contributor

@stxue1 stxue1 commented Apr 3, 2025

This should resolve #4927 once common-workflow-language/workflow-service#136 is merged into workflow-service.

Changelog Entry

To be copied to the draft changelog by merger:

  • Update to connexion 3

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@stxue1 stxue1 marked this pull request as ready for review May 14, 2025 21:24
Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but I think we should keep using secure_path() if we can, and I don't see a good reason why we can't.

file.save(dest)
has_attachments = True
body["workflow_attachment"] = (
"file://%s" % temp_dir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be encoding issues here if the temp directory has special characters in it, but they're not new to this PR.

Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now.

@adamnovak
Copy link
Member

wes-service 5.0 is on PyPI now so hopefully this passes.

@adamnovak adamnovak merged commit aca8a5c into master Jun 13, 2025
3 checks passed
@adamnovak adamnovak deleted the issues/4927-connexion-3 branch June 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connexion can't install with new Werkzeug and also MiniWDL

3 participants