fix: accept Graphsync measurements without HEAD status #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the regression introduced by e2a458b (#475) Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
requested review from
juliangruber,
pyropy and
NikolasHaimerl
as code owners
NikolasHaimerl
approved these changes
Mar 11, 2025
|
Thank you for fixing this! 🤗 |
bajtos
added a commit
to CheckerNetwork/spark-api
that referenced
this pull request
Mar 11, 2025
We have recently introduced a new requirement - when an HTTP retrieval succeeded, the checker is required to test HEAD retrieval request too. The preprocessing step in spark-evaluate discards measurements missing `head_status_code`. Because a large part of the network is running an older version of Spark Checker, measurements from these nodes are rejected as invalid. See CheckerNetwork/spark-evaluate#498. This patch is moving the validation step earlier to the pipeline by changing the minimum required Spark Checker version to 1.17.0. Checker nodes running an older version will start receiving a helpful "OUTDATED CLIENT" error response. Signed-off-by: Miroslav Bajtoš <[email protected]>
|
After deploying this fix, Spark RSR jumped back to ~20%, where it was before Feb 28th. 
|
bajtos
added a commit
to CheckerNetwork/spark-api
that referenced
this pull request
Mar 12, 2025
We have recently introduced a new requirement - when an HTTP retrieval succeeded, the checker is required to test HEAD retrieval request too. The preprocessing step in spark-evaluate discards measurements missing `head_status_code`. Because a large part of the network is running an older version of Spark Checker, measurements from these nodes are rejected as invalid. See CheckerNetwork/spark-evaluate#498. This patch is moving the validation step earlier to the pipeline by changing the minimum required Spark Checker version to 1.17.0. Checker nodes running an older version will start receiving a helpful "OUTDATED CLIENT" error response. Signed-off-by: Miroslav Bajtoš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression introduced by e2a458b (#475)
head_status_codeset to undefined or null.This pull requests relaxes the validation during preprocessing to assert numeric
head_status_codefor HTTP retrievals only.