fix: accept Graphsync measurements without HEAD status (#498)

Fix the regression introduced by e2a458b (#475)

Signed-off-by: Miroslav Bajtoš <[email protected]>

Author: bajtos

lib/preprocess.js

@@ -268,7 +268,14 @@ export const assertValidMeasurement = measurement => {
     assert(measurement.end_at >= measurement.first_byte_at, 'end_at must be greater than or equal to first_byte_at')
     assert(measurement.first_byte_at >= measurement.start_at, 'first_byte_at must be greater than or equal to start_at')
 
-    assert.strictEqual(typeof measurement.head_status_code, 'number', '`head_status_code` must be a number')
+    if (measurement.protocol === 'http') {
+      assert.strictEqual(typeof measurement.head_status_code, 'number', '`head_status_code` must be a number')
+    } else {
+      assert(
+        measurement.head_status_code === undefined || measurement.head_status_code === null,
+        '`head_status_code` must be undefined or null for non-HTTP retrievals'
+      )
+    }
   }
 }
 

test/preprocess.js

@@ -314,19 +314,48 @@ describe('assertValidMeasurement', () => {
     assert.throws(
       () => assertValidMeasurement({
         ...VALID_MEASUREMENT,
+        protocol: 'http',
         head_status_code: null
       }),
       /`head_status_code` must be a number/
     )
     assert.throws(
       () => assertValidMeasurement({
         ...VALID_MEASUREMENT,
+        protocol: 'http',
         head_status_code: /** @type {any} */ ('200')
       }),
       /`head_status_code` must be a number/
     )
   })
 
+  it('accepts Graphsync measurements with OK retrieval result and head_status_code is null', () => {
+    assertValidMeasurement({
+      ...VALID_MEASUREMENT,
+      protocol: 'graphsync',
+      head_status_code: null
+
+    })
+  })
+
+  it('accepts Graphsync measurements with OK retrieval result and head_status_code is undefined', () => {
+    assertValidMeasurement({
+      ...VALID_MEASUREMENT,
+      protocol: 'graphsync',
+      head_status_code: undefined
+    })
+  })
+
+  it('rejects Graphsync measurements with head_status_code not null/undefined ', () => {
+    assert.throws(
+      () => assertValidMeasurement({
+        ...VALID_MEASUREMENT,
+        head_status_code: /** @type {any} */ ('200')
+      }),
+      /`head_status_code` must be undefined/
+    )
+  })
+
   it('should throw an error for invalid start_at', () => {
     const measurement = {
       ...VALID_MEASUREMENT,