Skip to content

Commit 39ff6a1

Browse files
authored
feat: require Spark Checker version >=1.17.0 (#547)
We have recently introduced a new requirement - when an HTTP retrieval succeeded, the checker is required to test HEAD retrieval request too. The preprocessing step in spark-evaluate discards measurements missing `head_status_code`. Because a large part of the network is running an older version of Spark Checker, measurements from these nodes are rejected as invalid. See CheckerNetwork/spark-evaluate#498. This patch is moving the validation step earlier to the pipeline by changing the minimum required Spark Checker version to 1.17.0. Checker nodes running an older version will start receiving a helpful "OUTDATED CLIENT" error response. Signed-off-by: Miroslav Bajtoš <[email protected]>
1 parent 47c5c21 commit 39ff6a1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

api/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const createMeasurement = async (req, res, client) => {
5959
validate(measurement, 'sparkVersion', { type: 'string', required: false })
6060
validate(measurement, 'zinniaVersion', { type: 'string', required: false })
6161
assert(
62-
typeof measurement.sparkVersion === 'string' && satisfies(measurement.sparkVersion, '>=1.13.0'),
62+
typeof measurement.sparkVersion === 'string' && satisfies(measurement.sparkVersion, '>=1.17.0'),
6363
410, 'OUTDATED CLIENT'
6464
)
6565

api/test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { createTelemetryRecorderStub } from '../../test-helpers/platform-test-he
1414

1515
const { DATABASE_URL } = process.env
1616
const participantAddress = '0x000000000000000000000000000000000000dEaD'
17-
const sparkVersion = '1.13.0' // This must be in sync with the minimum supported client version
17+
const sparkVersion = '1.17.0' // This must be in sync with the minimum supported client version
1818
const currentSparkRoundNumber = 42n
1919

2020
const VALID_DEAL_INGESTION_TOKEN = 'authorized-token'

0 commit comments

Comments
 (0)