Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 14, 2025

Bot reviewer identified that render_bibliography_to_strings() returns "citeproc-py" but tests were checking for "citeproc". A prior commit incorrectly changed the implementation instead of the tests, breaking other tests expecting "citeproc-py".

Changes

  • api.py: Reverted render_bibliography_to_strings() to return "citeproc-py" in metadata
  • test_rendering.py: Updated assertions to check for "citeproc-py" in:
    • test_render_bibliography_multiple_citations (line 176)
    • test_render_bibliography_apa_style (line 107)

Using "citeproc-py" aligns with the actual package name and existing test expectations.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Contributor Author

Copilot AI commented Dec 14, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)
  • eutils.ncbi.nlm.nih.gov
    • Triggering command: /usr/bin/python3 python3 -m pytest tests/unit/ -v --tb=short (dns block)
  • www.ncbi.nlm.nih.gov
    • Triggering command: /usr/bin/python3 python3 -m pytest tests/unit/ -v --tb=short (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on adding missing dependency and testing improvements Fix renderer metadata value: use "citeproc-py" consistently Dec 14, 2025
Copilot AI requested a review from dosumis December 14, 2025 15:17
Base automatically changed from ID_lookup_fix to main December 14, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants