added env vars to docker #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saransh323
requested changes
Jan 13, 2025
TiaSinghania
commented
Jan 14, 2025
TiaSinghania
commented
Jan 14, 2025
|
I can run through this today during software meeting. |
mehulgoel873
approved these changes
Jan 14, 2025
BruceMcRooster
approved these changes
Jan 14, 2025
Comment on lines
24
to
+28
| echo 'cd rb_ws' >> ~/.bashrc && \ | ||
| echo 'colcon build --symlink-install' >> ~/.bashrc && \ | ||
| echo 'source install/local_setup.bash' >> ~/.bashrc && \ | ||
| echo 'chmod -R +x src/buggy/scripts/' >> ~/.bashrc | ||
| echo 'chmod -R +x src/buggy/scripts/' >> ~/.bashrc && \ | ||
| echo 'source environments/docker_env.bash' >> ~/.bashrc |
There was a problem hiding this comment.
This could be a separate refactor, but I think making this a single command across several lines would be more readable.
This would look something like
echo -e '\
source "/opt/ros/humble/setup.bash" -- \n\
cd rb_ws \n\
colcon build --symlink-install \n\
...
' >> ~/.bashrcThe key to this is the -e flag passed to echo that enables the \n newline character, and using \ to include multiple lines in the command. Writing it this way makes the readability of the actual commands we want to run more apparent.
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Describe the CHANGES, the REASONING, and BENEFITS of this PR.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?