-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dockerfile bashrc config readability #120
Closed
BruceMcRooster
wants to merge
72
commits into
CMU-Robotics-Club:main
from
CMU-Robotics-Club:improve-dockerfile-bashrc-config-readability
Closed
Improve dockerfile bashrc config readability #120
BruceMcRooster
wants to merge
72
commits into
CMU-Robotics-Club:main
from
CMU-Robotics-Club:improve-dockerfile-bashrc-config-readability
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engine rewrite
Porting Ros2Bnyahaj
…write Buggy State Converter Rewrite
Co-authored-by: Jackack <[email protected]>
Co-authored-by: Jackack <[email protected]>
Co-authored-by: Mehul Goel <[email protected]>
BruceMcRooster
force-pushed
the
improve-dockerfile-bashrc-config-readability
branch
from
January 15, 2025 00:18
7040628
to
c335660
Compare
Whoops, wrong repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This makes the actual script that is written to
~/.bashrc
by the Dockerfile more readable.Readability is usually a good thing. Just look at the side-by-side comparison view.
Related Tickets & Documents
I referenced making a change like this when reviewing another PR; here was my comment. It was slightly modified to ensure consistency and that it worked
Testing
This has been tested in the Docker container, but if you want to try it yourself, boot up a container. You shouldn't see any errors in the Dockerfile or in bash when it starts up. Checking the bottom of
~/.bashrc
should show the correct code, reproduced below, with no weird trailing characters, aside from some spaces that were added for better formatting of the Dockerfile.