Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dockerfile bashrc config readability #120

Conversation

BruceMcRooster
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This makes the actual script that is written to ~/.bashrc by the Dockerfile more readable.
Readability is usually a good thing. Just look at the side-by-side comparison view.

Related Tickets & Documents

I referenced making a change like this when reviewing another PR; here was my comment. It was slightly modified to ensure consistency and that it worked

Testing

This has been tested in the Docker container, but if you want to try it yourself, boot up a container. You shouldn't see any errors in the Dockerfile or in bash when it starts up. Checking the bottom of ~/.bashrc should show the correct code, reproduced below, with no weird trailing characters, aside from some spaces that were added for better formatting of the Dockerfile.

# automatically generated by Dockerfile 
source "/opt/ros/humble/setup.bash" --                
cd rb_ws                                              
colcon build --symlink-install                        
source install/local_setup.bash                       
chmod -R +x src/buggy/scripts/                        
source environments/docker_env.bash                   

@BruceMcRooster BruceMcRooster force-pushed the improve-dockerfile-bashrc-config-readability branch from 7040628 to c335660 Compare January 15, 2025 00:18
@BruceMcRooster
Copy link
Member Author

Whoops, wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants