Skip to content

Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2352f4
Initial plan
Copilot Mar 30, 2026
c3dd4b3
Remove duplication between test_compute_weight_factors.py and test_me…
Copilot Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 0 additions & 112 deletions model/common/tests/common/metrics/unit_tests/test_compute_weight_factors.py
View file
Open in desktop

This file was deleted.

20 changes: 20 additions & 0 deletions model/common/tests/common/metrics/unit_tests/test_metrics_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,26 @@ def test_factory_coeff_gradekin(
assert test_helpers.dallclose(field_ref.asnumpy(), field.asnumpy(), rtol=1e-8)


@pytest.mark.level("integration")
@pytest.mark.datatest
def test_factory_wgtfacq_c(
grid_savepoint: serialbox.IconGridSavepoint,
metrics_savepoint: serialbox.MetricSavepoint,
topography_savepoint: serialbox.TopographySavepoint,
experiment: definitions.Experiment,
backend: gtx_typing.Backend | None,
) -> None:
factory = _get_metrics_factory(
backend=backend,
experiment=experiment,
grid_savepoint=grid_savepoint,
topography_savepoint=topography_savepoint,
)
field = factory.get(attrs.WGTFACQ_C)
field_ref = metrics_savepoint.wgtfacq_c()
assert test_helpers.dallclose(field_ref.asnumpy(), field.asnumpy())


@pytest.mark.level("integration")
@pytest.mark.datatest
def test_factory_wgtfacq_e(
Expand Down