Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py#1181
Draft
Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py#1181
Conversation
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
…trics_factory.py - Add test_factory_wgtfacq_c to test_metrics_factory.py for WGTFACQ_C coverage - Remove test_compute_weight_factors.py (all tests now covered by factory tests) Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/c16da518-be23-48a9-ac02-71b17d5f861d Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove duplication between test_compute_weight_factors and test_metrics_factory
Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_compute_weight_factors.pytested weight factor computations directly, duplicating coverage already intest_metrics_factory.pyvia the factory pattern.test_compute_weight_factors.py— all 3 tests (test_compute_wgtfac_c,test_compute_wgtfacq_e_dsl,test_compute_wgtfacq_c_dsl) had factory equivalentstest_factory_wgtfacq_ctotest_metrics_factory.py— the only computation that lacked a factory-level testtest_compute_wgtfac_ctest_compute_wgtfac_ctest_compute_wgtfacq_e_dsltest_factory_wgtfacq_etest_compute_wgtfacq_c_dsltest_factory_wgtfacq_c(new)📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.