-
Notifications
You must be signed in to change notification settings - Fork 2k
Add two new solutions to the cancellation flow #69567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~20 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~728 bytes added 📈 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~45 bytes added 📈 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7599594 Thank you @taggon for including a screenshot in the description! This is really helpful for our translators. |
653346c to
d3cbb51
Compare
|
Rebased |
|
Hi there! Noticed a small typo in this PR.
biennual --> biannual. |
|
Translation for this Pull Request has now been finished. |
|
@emilyaudela Thanks! It is fixed now. :) |
433e0ae to
b1e389f
Compare
|
Rebased. |
b1e389f to
7a42648
Compare
7a42648 to
7061c74
Compare
| isPrimary | ||
| href={ props.acceptButtonUrl } | ||
| onClick={ () => { | ||
| setBusyButton( 'accept' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! 👋 I found an issue with this component while working on #78711. Essentially, if href is provided, then a is rendered instead of a button. This means disabled cannot be accepted. However, I see we have an onClick method as well.
There are two conflicting solutions. Could you let me know which should be used?
- Remove the
hrefbecause it isn't a link - Remove
disabledbecause it isn't a button
Proposed Changes
Testing Instructions
Downgrade to Monthly Plansolution when you choosePrice/Budget > It's too expensive.Pre-merge Checklist
Related to #