Skip to content

Conversation

@taggon
Copy link
Contributor

@taggon taggon commented Oct 28, 2022

Proposed Changes

  • This PR adds two new solutions - Live Chat and Built By - to the cancellation flow and also applies fresh visual styles to the flow as a part of the Cancelation Reason/Solutions project. For more details, see pebzTe-kL-p2

Testing Instructions

  • Try to cancel/remove your paid plan.
  • You would be taken to the solutions based on the reason you picked. Visit pebzTe-nt-p2 to see the reasons and the relevant solutions. For example, you will see the Downgrade to Monthly Plan solution when you choose Price/Budget > It's too expensive.
    화면_기록_2022-10-28_오후_9_01_03_mov
    화면_기록_2022-10-28_오후_9_01_03_mov
  • Make sure the buttons work properly.
  • For testing LiveChat, see pebzTe-sj-p2

Pre-merge Checklist

Related to #

@taggon taggon self-assigned this Oct 28, 2022
@github-actions
Copy link

github-actions bot commented Oct 28, 2022

@taggon taggon added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. Upsell Nudge labels Oct 28, 2022
@matticbot
Copy link
Contributor

matticbot commented Oct 28, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~20 bytes added 📈 [gzipped])

Details
name           parsed_size           gzip_size
entry-stepper       +120 B  (+0.0%)      +23 B  (+0.0%)
entry-main          +120 B  (+0.0%)      +23 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~728 bytes added 📈 [gzipped])

Details
name            parsed_size           gzip_size
site-purchases       +975 B  (+0.1%)     +709 B  (+0.2%)
purchases            +975 B  (+0.1%)     +709 B  (+0.2%)
domains              +838 B  (+0.1%)     +689 B  (+0.2%)
help                 +217 B  (+0.0%)      +19 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~45 bytes added 📈 [gzipped])

Details
name                                           parsed_size           gzip_size
async-load-calypso-blocks-inline-help-popover       +337 B  (+0.0%)      +45 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taggon taggon added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 28, 2022
@taggon taggon changed the base branch from trunk to update/improve-cancellation-flow-again October 28, 2022 12:57
@a8ci18n
Copy link

a8ci18n commented Oct 28, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7599594

Thank you @taggon for including a screenshot in the description! This is really helpful for our translators.

@taggon taggon force-pushed the update/solutions-with-live-chat-and-built-by branch from 653346c to d3cbb51 Compare October 31, 2022 06:05
@taggon
Copy link
Contributor Author

taggon commented Oct 31, 2022

Rebased

@taggon taggon marked this pull request as ready for review October 31, 2022 06:06
@taggon taggon added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 31, 2022
@emilyaudela
Copy link
Contributor

Hi there! Noticed a small typo in this PR.

You will lose your free domain registration since that feature is only included in annual/biennual plans.

biennual --> biannual.

Base automatically changed from update/improve-cancellation-flow-again to trunk November 3, 2022 05:25
@a8ci18n
Copy link

a8ci18n commented Nov 3, 2022

Translation for this Pull Request has now been finished.

@taggon
Copy link
Contributor Author

taggon commented Nov 4, 2022

@emilyaudela Thanks! It is fixed now. :)

@taggon taggon force-pushed the update/solutions-with-live-chat-and-built-by branch from 433e0ae to b1e389f Compare November 4, 2022 07:49
@taggon
Copy link
Contributor Author

taggon commented Nov 4, 2022

Rebased.

@taggon taggon force-pushed the update/solutions-with-live-chat-and-built-by branch from b1e389f to 7a42648 Compare November 16, 2022 05:45
@taggon taggon force-pushed the update/solutions-with-live-chat-and-built-by branch from 7a42648 to 7061c74 Compare November 16, 2022 12:13
@taggon taggon merged commit ea0f0b2 into trunk Nov 22, 2022
@taggon taggon deleted the update/solutions-with-live-chat-and-built-by branch November 22, 2022 22:46
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Nov 22, 2022
@taggon taggon mentioned this pull request Nov 24, 2022
6 tasks
isPrimary
href={ props.acceptButtonUrl }
onClick={ () => {
setBusyButton( 'accept' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 I found an issue with this component while working on #78711. Essentially, if href is provided, then a is rendered instead of a button. This means disabled cannot be accepted. However, I see we have an onClick method as well.

There are two conflicting solutions. Could you let me know which should be used?

  1. Remove the href because it isn't a link
  2. Remove disabled because it isn't a button

@heavyweight heavyweight mentioned this pull request Mar 6, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Upsell Nudge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants