Skip to content

Conversation

@taggon
Copy link
Contributor

@taggon taggon commented Nov 11, 2022

Proposed Changes

As a part of the cancellation flow project( pebzTe-kL-p2 ), this PR adds educational content to the cancellation flow. The new content will be shown when a user picks specific answers. For more dedtails, check out pdZzpt-e9-p2.

Note that this PR is based on #69567. You should merge the preceding PR first.

Testing Instructions

  • Attempt to cancel your paid plan.
  • When you choose Technical issues > SEO issues, you should be able to see the educational content.
    Cancel_Purchase_‹_Taggon_on_wordpress_—_WordPress_com
  • The open question form will show up if you click on the Cancel my current plan button.

Other educational resources will like as follows:
Cancel_Purchase_‹_Taggon_on_wordpress_—_WordPress_com
Cancel_Purchase_‹_Taggon_on_wordpress_—_WordPress_com
Cancelation_flow_–_Figma

Pre-merge Checklist

  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #

@github-actions
Copy link

github-actions bot commented Nov 11, 2022

@taggon taggon marked this pull request as ready for review November 11, 2022 15:42
@taggon taggon self-assigned this Nov 11, 2022
@taggon taggon added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. labels Nov 11, 2022
@JanaMW27
Copy link

Why the top nav is a bit different? there is no help access and the site name label is to the right rather than centered.

What I see:

Screenshot 2022-11-11 at 10 26 15

What it should be:
Screenshot 2022-11-11 at 10 26 49

And can we reduce the current space between the "Thanks, but this..." and the CTA?:
Screenshot 2022-11-11 at 10 27 35

Thanks!

@southp southp requested review from a team and southp November 14, 2022 01:51
Copy link
Member

@dzver dzver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall works as expected. Left 3 questions about copy and styling.

@dzver
Copy link
Member

dzver commented Nov 14, 2022

I actually didn't test the test by a11n message because it's not part of the test plan. Should I have found a way to test it?

@taggon taggon force-pushed the update/solutions-with-live-chat-and-built-by branch 2 times, most recently from 7a42648 to 7061c74 Compare November 16, 2022 12:13
@taggon taggon force-pushed the add/educational-resources-to-cancellation-flow branch from 0a6f738 to 15fb232 Compare November 16, 2022 13:47
@taggon
Copy link
Contributor Author

taggon commented Nov 16, 2022

I actually didn't test the test by a11n message because it's not part of the test plan. Should I have found a way to test it?

@dzver See pebzTe-sj-p2 😄

@matticbot
Copy link
Contributor

matticbot commented Nov 16, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2081 bytes added 📈 [gzipped])

Details
name            parsed_size           gzip_size
site-purchases      +8574 B  (+0.6%)    +2081 B  (+0.6%)
purchases           +8574 B  (+0.5%)    +2081 B  (+0.4%)
domains             +8574 B  (+0.5%)    +2081 B  (+0.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taggon taggon added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Nov 16, 2022
@a8ci18n
Copy link

a8ci18n commented Nov 16, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7625875

Thank you @taggon for including a screenshot in the description! This is really helpful for our translators.

Copy link
Member

@dzver dzver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all the copy and the code and it looks good to me but I still see a merge conflict.

<ul>
<li>
{ translate(
'Go to Upgrades → Domains and click {{link}}Add a Domain{{/link}} to register your plan’s free domain',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not quite apply if they're on a monthly plan and cancelling it but I think we can ship and iterate if this step turns out to be successful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from update/solutions-with-live-chat-and-built-by to trunk November 22, 2022 22:46
@taggon taggon force-pushed the add/educational-resources-to-cancellation-flow branch from ee0772b to 304744e Compare November 22, 2022 23:27
@taggon
Copy link
Contributor Author

taggon commented Nov 22, 2022

Rebased.

@taggon taggon force-pushed the add/educational-resources-to-cancellation-flow branch from 304744e to 871c5a1 Compare November 24, 2022 15:14
@taggon
Copy link
Contributor Author

taggon commented Nov 24, 2022

Rebased

@a8ci18n
Copy link

a8ci18n commented Nov 24, 2022

Translation for this Pull Request has now been finished.

@taggon taggon merged commit 2d41a91 into trunk Nov 25, 2022
@taggon taggon deleted the add/educational-resources-to-cancellation-flow branch November 25, 2022 03:01
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants