Skip to content

Conversation

@taggon
Copy link
Contributor

@taggon taggon commented Nov 24, 2022

Proposed Changes

Testing Instructions

Pre-merge Checklist

  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #69567

@taggon taggon self-assigned this Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 24, 2022

@taggon taggon added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com. labels Nov 24, 2022
@taggon taggon marked this pull request as ready for review November 24, 2022 07:17
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes added 📈 [gzipped])

Details
name            parsed_size           gzip_size
site-purchases       +110 B  (+0.0%)      +14 B  (+0.0%)
purchases            +110 B  (+0.0%)      +14 B  (+0.0%)
domains              +110 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taggon taggon merged commit cdf500d into trunk Nov 24, 2022
@taggon taggon deleted the update/temporarily-disable-livechat-solutions branch November 24, 2022 12:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature Group] A8C Marketing & Sales Automattic's marketing and sales operations for WordPress.com.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants