-
Notifications
You must be signed in to change notification settings - Fork 118
Project Meeting 2025.05.13
rcopperman edited this page May 14, 2025
·
2 revisions
- Skim Variables Input Check update (CS)
- Input validation check update (CS)
- Skim Variables Input Check Update
- Without Sharrow: Set-up system so that when you are loading skims, a warning was added stating that a condition exists that when you move to Sharrow that it will be an issue
- Change does not really impact model w/o Sharrow
- Can ignore warning
- With Sharrow: An error message added explaining the issue and telling how to solve the problem
- To run in Sharrow all the inputs must have all of the same names
- Error instructs you to change the names to be the same
- Documentation is in pull requests
- David H (RSG) assigned to pull request review
- Without Sharrow: Set-up system so that when you are loading skims, a warning was added stating that a condition exists that when you move to Sharrow that it will be an issue
- Input validation check update
- Added settings_checker.py module
- Collect all models
- Runs a "smoke test" to check for errors
- Progress
- Refined framework
- Registered 44 model steps
- Created settings_checker.log
- Added error collection: collected and raised errors; report exceptions
- Tested against example models
- Excluded
- Components w/o YAML files
- _RUNNABLE_STEPS
- Models with missing configs in example models
- Three untested models not included in canonical examples
- Models that are only part of extensions
- Limitations
- Models that move SPEC_SEGMENTS
- Coefficient evaluation is only checked when both valid Spec and Coefficients data is available; non-fatal (warning)
- Script is case sensitive, so sometimes not all variances of file names are included
- Unique settings
- Next Steps
- Small tweaks to logging and error reporting
- Push final changes and open a Pull Request
- Assign a reviewer and get more detailed feedback
- Other YAML files that may need to be included: Network LOS, Logging File, Shadow Pricing, Constants; outputs
- Not treated as "Models"; Scope was limited to Models and not runnable steps
- Can be an option to include a subset of the runnable steps into the checker
- Current model, has all files checked at the time when the file is run; This update will check files ahead of time.
- Purposely made the checker non-configurable - will be hard coded
- Can add extensions into list
- SANDAG noted that not all extensions are necessary
- Run time - a couple of seconds
- Revised Next Steps: Chat with David H and Jeff N about what else needs to be checked at start of run
- Can check in again in ~2 weeks; Suggest brief update on Thursday, May 29th
- Added settings_checker.py module
- Next meeting: Roadmap check-in; Admin updates;
- 5/22 meeting - update on dependency task