drivers: input: add ft6146 driver #96330
Conversation
ck-telecom
force-pushed
the
ft6146
branch
6 times, most recently
from
870fa56 to
a41e843
Compare
ck-telecom
force-pushed
the
ft6146
branch
4 times, most recently
from
d3e4ab3 to
c8a9983
Compare
|
@ck-telecom hey feel free to undraft when you want another round on review, meanwhile in case you missed it check the sonarqubecloud comment as well, there' some valid stuff in there. |
ck-telecom
force-pushed
the
ft6146
branch
2 times, most recently
from
64d0be9 to
ca548af
Compare
|
I'm a bit confused, why did you remove the device ID check? That was a very useful to have, I was just asking to change the return code and fix the error message to always show the full 16 bits |
the chip id in my board is not same with original driver(other platform), so for now just ignore it coz I can't find the datasheet from the internet. |
drivers/input/input_ft6146.c
Outdated
| return; | ||
| } | ||
|
|
||
| for (int i = 0; i < touch_num; i++) { |
There was a problem hiding this comment.
does it make sense to process all the touch_num? how does this react to multiple touches?
|
few compliance checks are failing, can you take a look? https://github.com/zephyrproject-rtos/zephyr/actions/runs/18906468271/job/53965816759?pr=96330 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the FocalTech FT6146 capacitive touch controller driver to Zephyr. The implementation follows the existing FT5336 driver pattern with support for both interrupt-driven and polling modes.
Key Changes
- Adds FT6146 touch controller driver implementation with I2C communication
- Provides device tree bindings and overlay configuration for the new controller
- Integrates the driver into the build system with appropriate Kconfig options
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/input/input_ft6146.c | New driver implementation for FT6146 touch controller with interrupt and polling mode support |
| dts/bindings/input/focaltech,ft6146.yaml | Device tree bindings definition for FT6146 controller |
| drivers/input/Kconfig.ft6146 | Kconfig options for FT6146 driver configuration |
| drivers/input/Kconfig | Integration of FT6146 Kconfig into main input drivers configuration |
| drivers/input/CMakeLists.txt | Build system integration for FT6146 driver |
| tests/drivers/build_all/input/app.overlay | Test overlay configuration including FT6146 device node and formatting improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
add initial driver for ft6146 Signed-off-by: Qingsong Gou <[email protected]>
|
5 participants
add initial driver for ft6146