Add support for Renesas RA CEU (Capture Engine Unit) for RA8M1 and RA8D1 #92146

thaoluonguw · 2025-06-25T04:36:39Z

Add support for Renesas RA CEU (Capture Engine Unit):

Add video driver use CEU
Add dts for CEU on RA8M1 and RA8D1
Enable CEU support for EK-RA8D1
Add support for EK-RA8D1 on Video capture to LVGL sample.
It works with OV7670 camera, and MIPI graphics expansion board included in the Kit

Update hal_renesas to support CEU on RA SoCs Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

Add support for the Renesas RA Capture Engine Unit (CEU), including driver source files, Kconfig options, and DTS bindings. - Add initial implementation of the RA CEU driver - Add dedicated Kconfig and CMake integration - Provide Devicetree bindings for the RA CEU - Update module Kconfig to include the new driver This enables image capture functionality using the CEU peripheral on Renesas RA series MCUs. Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

Add pin definitions required by the RA Capture Engine Unit Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

Add CEU to r7fa8d1xh.dtsi and r7fa8m1xh.dtsi Signed-off-by: Khanh Nguyen <[email protected]>

- Add CEU pin configuration to ek_ra8d1-pinctrl.dtsi - Enable CEU node and Arducam 20-pin connector in ek_ra8d1.dts - Configure PWM3 as external XCLK via pwm-clock node - Update board YAML to declare video support Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

Add EK-RA8D1 board support for the capture_to_lvgl sample - Add board-specific configuration in ek_ra8d1.conf - Add Devicetree overlay enabling CEU and display path Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

Add SW1 configuration for using Camera Exapansion Port (J59) Signed-off-by: Thao Luong <[email protected]>

github-actions · 2025-06-25T04:38:07Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_renesas	zephyrproject-rtos/hal_renesas@`0769fe1` (`main`)	zephyrproject-rtos/hal_renesas#113	zephyrproject-rtos/hal_renesas#113/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

sonarqubecloud · 2025-06-25T05:02:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

josuah

Thank you for implementing the Renesas video driver!

The driver appears in a good shape WRT video APIs, with a few key points to modify (marked with :x), and a few proposal to improve it further, non-blocking (i.e. could be improved over time eventually, although appreciated if modified now).

Let me know if anything needs clarifications.

josuah · 2025-06-25T13:16:23Z

drivers/video/Kconfig.renesas_ra_ceu

+config VIDEO_RENESAS_BUFFER_SDRAM
+	bool "Allocate the video buffer into SDRAM"
+	depends on VIDEO_RENESAS_RA_CEU
+	select MEMC
+	help
+	  Allocate the video buffer into SDRAM


[non-blocking]
If interested, there is another mechanism to select the type of memory for use as video buffer memory: Shared Multi-Heap (SMH).

Here is an example that compares how this was implemented in both ST and Espressif side for information:
56e69e5

This gives the user the final choice of what memory source to use.

josuah · 2025-06-25T13:29:51Z

drivers/video/video_renesas_ra_ceu.c

+	if (fmt->width % CEU_WIDTH_ALIGN) {
+		LOG_DBG("Width %d not a multiple of %d", fmt->width, CEU_WIDTH_ALIGN);
+		return -ENOTSUP;
+	}
+	if (fmt->height % CEU_HEIGHT_ALIGN) {
+		LOG_DBG("Height %d not a multiple of %d", fmt->height, CEU_HEIGHT_ALIGN);
+		return -ENOTSUP;
+	}


[non-blocking]
To help with compliance effort in the future, is it possible to compare against 0 so that the expression is a boolean?

Suggested change

if (fmt->width % CEU_WIDTH_ALIGN) {

LOG_DBG("Width %d not a multiple of %d", fmt->width, CEU_WIDTH_ALIGN);

return -ENOTSUP;

}

if (fmt->height % CEU_HEIGHT_ALIGN) {

LOG_DBG("Height %d not a multiple of %d", fmt->height, CEU_HEIGHT_ALIGN);

return -ENOTSUP;

}

if (fmt->width % CEU_WIDTH_ALIGN != 0) {

The subset of MISRA recommended for Zephyr developers is listed here.

josuah · 2025-06-25T13:35:21Z

drivers/video/video_renesas_ra_ceu.c

+	if (!enable) {
+		if (video_stream_stop(config->source_dev, type)) {
+			LOG_DBG("Failed to stop source device stream");
+			return -EIO;
+		}
+
+		data->is_streaming = false;
+		R_CEU->CAPSR = R_CEU_CAPSR_CPKIL_Msk;
+	}


[non-blocking]
If enable == false, then the if will execute, but what is after it as well as there is no return 0;, maybe this was not intentional.

josuah · 2025-06-25T13:55:20Z

drivers/video/video_renesas_ra_ceu.c

+	if (video_stream_start(config->source_dev, type)) {
+		LOG_DBG("Failed to start source device stream");
+		return -EIO;
+	}


[non-blocking]
While this code is working, the following would be slightly more conventional:

Suggested change

if (video_stream_start(config->source_dev, type)) {

LOG_DBG("Failed to start source device stream");

return -EIO;

}

int ret;

...

ret = video_stream_start(config->source_dev, type)

if (ret < 0) {

LOG_DBG("Failed to start source device stream");

return ret;

}

josuah · 2025-06-25T14:01:07Z

drivers/video/video_renesas_ra_ceu.c

+		if (video_stream_stop(config->source_dev, type)) {
+			LOG_DBG("Failed to stop source device stream");
+			return -EIO;
+		}


[non-blocking]
While this code is working, the following would be slightly more conventional:

Suggested change

if (video_stream_stop(config->source_dev, type)) {

LOG_DBG("Failed to stop source device stream");

return -EIO;

}

int ret;

...

video_stream_stop(config->source_dev, type);

if (ret < 0) {

LOG_DBG("Failed to stop source device stream");

return ret;

}

There does not seem to be any policy for use of ret vs err or ret < 0 vs ret != 0.

One possible way to handle error codes from the HAL and error codes from Zephyr is to use err for HAL errors and ret for Zephyr errors.

Coding guidelines are non-blocking at the moment, however! This is only anticipating the moment where certification would video drivers.

josuah · 2025-06-25T23:39:15Z

samples/drivers/video/capture_to_lvgl/boards/ek_ra8d1.overlay

+			bus-width = <8>;
+			hsync-active = <1>;
+			vsync-active = <1>;
+			pclk-sample = <1>;
+			hsync-sample = <0>;
+			vsync-sample = <0>;


[non-blocking]
It seems like all these properties are specific to the ov7670 more than specific to this board. For instance, if the user wants to try with a different image sensor shield, they might need different values at this place.

It might be possible to move these properties to boards/shields/dvp_20pin_ov7670/dvp_20pin_ov7670.overlay:

&dvp_20pin_ep_in { bus-width = <8>; hsync-active = <1>; vsync-active = <1>; pclk-sample = <1>; hsync-sample = <0>; vsync-sample = <0>; };

All these properties are expected to always exist, even if they are not used by drivers, so this is not expected t to break the other boards... Except for hsync-sample and vsync-sample not defined on dts/bindings/video/video-interfaces.yaml.

Then, on boards/renesas/ek_ra8d1/ek_ra8d1.dts, it is possible to define an empty endpoint, just for the purpose of declaring the label:

&ceu { ... port { dvp_20pin_ep_in: endpoint { remote-endpoint-label = ""; }; }; };

josuah · 2025-06-25T23:46:02Z

samples/drivers/video/capture_to_lvgl/boards/ek_ra8d1.overlay

+};
+
+&dvp_20pin_i2c {
+	status = "okay";


[non-blocking]
status = "okay"; should have been enabled in the ov7670 module: a bug in the module definition.
Do feel free to move this line to here if you wish, otherwise I will open a new pull request to fix OV7670:

zephyr/boards/shields/dvp_20pin_ov7670/dvp_20pin_ov7670.overlay

Line 14 in c906d4a

&dvp_20pin_i2c {

josuah · 2025-06-25T23:50:22Z

samples/drivers/video/capture_to_lvgl/boards/ek_ra8d1.overlay

+&dvp_20pin_connector {
+	status = "okay";
+};


[blocking ❌]
The connector is a mere mapping of GPIO pins usually without an associated device.
It is also not status = "disabled"; by the boards/renesas/ek_ra8d1/ek_ra8d1.dts where it is defined.
As far as I understand, this is redundant. Let me know if I missed something.

josuah · 2025-06-25T23:51:34Z

samples/drivers/video/capture_to_lvgl/boards/ek_ra8d1.overlay

+&dvp_20pin_interface {
+	status = "okay";


[non-blocking]
The status = "okay"; is already performed by the shield, and does not seems necessary there.

zephyr/boards/shields/dvp_20pin_ov7670/dvp_20pin_ov7670.overlay

Lines 29 to 30 in c906d4a

&dvp_20pin_interface {

status = "okay";

josuah · 2025-06-25T23:56:39Z

samples/drivers/video/capture_to_lvgl/boards/ek_ra8d1.overlay

+	swap-8bits;
+	swap-16bits;
+	swap-32bits;


[non-blocking]
The remaining properties may be added to the shield-specific configuration file.
It will be possible to add a /boards/shields/dvp_20pin_ov7670/boards/ek_ra8d1.overlay that contains all the board-specific integration with a module.
This way, you do not need to re-define these parameters on every sample, and users can select any sensor.

josuah · 2025-06-26T00:09:58Z

[blocking ❌]
In order to make sure this driver always compiles even after Video APIs are refactored, you may want to add it to this test that will run on CI on every video-related commit:
tests/drivers/build_all/video/app.overlay

ngphibang · 2025-06-27T23:04:04Z

drivers/video/video_renesas_ra_ceu.c

+	}
+}
+
+static int video_renesas_ra_ceu_get_format(const struct device *dev, struct video_format *fmt)


Function name is rather long, could it be shorten like ra_ceu_get_format ?. Idem for others

ngphibang · 2025-06-27T23:14:19Z

drivers/video/video_renesas_ra_ceu.c

+	fsp_err_t err;
+	int ret;
+
+	fmt->pitch = fmt->width * video_bits_per_pixel(fmt->pixelformat) / BITS_PER_BYTE;


not a big deal but fmt->pitch should be computed at the end when everything is OK as it is the value that application will read back.

ngphibang · 2025-06-27T23:18:23Z

dts/bindings/video/renesas,ra-ceu.yaml

+child-binding:
+  child-binding:
+    include: video-interfaces.yaml
+
+    properties:
+      hsync-active:
+        required: true
+
+      vsync-active:
+        required: true
+
+      pclk-sample:
+        required: true
+
+      vsync-sample:
+        required: true
+        type: int
+        enum:
+          - 0 # Falling edge
+          - 1 # Rising edge
+        description: |
+          Sample on the falling or rising edge of the vsync signal.
+
+      hsync-sample:
+        required: true
+        type: int
+        enum:
+          - 0 # Falling edge
+          - 1 # Rising edge
+        description: |
+          Sample on the falling or rising edge of the hsync signal.
+
+      bus-width:


Why do you redefine many properties that are already defined in video-interfaces.yaml ?

KhanhNguyen-RVC and others added 7 commits June 25, 2025 09:50

manifest: Update hal_renesas to support CEU on RA SoCs

dfbc9b7

Update hal_renesas to support CEU on RA SoCs Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

include: dt-bindings: renesas: Add RA CEU pin definitions

799fccf

Add pin definitions required by the RA Capture Engine Unit Signed-off-by: Duy Vo <[email protected]> Signed-off-by: Khanh Nguyen <[email protected]>

dts: arm: renesas: Add CEU nodes for RA8D1 and RA8M1 SoCs

fca0cf8

Add CEU to r7fa8d1xh.dtsi and r7fa8m1xh.dtsi Signed-off-by: Khanh Nguyen <[email protected]>

boards: renesas: ek_ra8d1: Update document for using Camera

92a4b3b

Add SW1 configuration for using Camera Exapansion Port (J59) Signed-off-by: Thao Luong <[email protected]>

thaoluonguw requested review from soburi, KhiemNguyenT, thenguyenyf and duynguyenxa June 25, 2025 04:36

thaoluonguw added this to the v4.3.0 milestone Jun 25, 2025

github-actions bot added area: Pinctrl platform: Renesas RA Renesas Electronics Corporation, RA area: Video Video subsystem area: Samples Samples labels Jun 25, 2025

github-actions bot requested review from avolmat-st, gmarull, josuah, kartben, loicpoulain, nashif and ngphibang June 25, 2025 04:37

github-actions bot assigned josuah and ngphibang Jun 25, 2025

github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 25, 2025

josuah requested changes Jun 26, 2025

View reviewed changes

ngphibang reviewed Jun 27, 2025

View reviewed changes

Add support for Renesas RA CEU (Capture Engine Unit) for RA8M1 and RA8D1 #92146

Are you sure you want to change the base?

Add support for Renesas RA CEU (Capture Engine Unit) for RA8M1 and RA8D1 #92146

Conversation

thaoluonguw commented Jun 25, 2025

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

sonarqubecloud bot commented Jun 25, 2025

Quality Gate passed

Uh oh!

josuah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josuah commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngphibang Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josuah commented Jun 26, 2025 •

edited

Loading

ngphibang Jun 27, 2025 •

edited

Loading