-
Notifications
You must be signed in to change notification settings - Fork 7.5k
boards: nxp: imx95_evk_15x15: add i.MX 95 15x15 LPDDR4x EVK variant #90744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
boards: nxp: imx95_evk_15x15: add i.MX 95 15x15 LPDDR4x EVK variant #90744
Conversation
# Copyright 2024 NXP | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
config BOARD_IMX95_EVK_15X15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to add a new board for 15x15?
On a quick look all files you added here are the same as those from imx95_evk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the commit, which should show more difference between the two boards (especially the doc/index.rst and the different pinctrl dtsi).
We need a different board due to the different packaging of the SoC (with slight differences in the pinctrl DTSI) and to adapt to the differences in peripherals between the two boards.
The current patch only adds an initial support, so it is for now very similar to the imx95_evk board, but it will diverge at some point (for instance for the usage of the different ethernet interfaces). So, to avoid future conflict, we started a separate board support for it right away.
CC: @GhMarwen
a9f91b3
to
0d2d5f4
Compare
Please fix twister issue. |
0d2d5f4
to
db70bf9
Compare
db70bf9
to
d4758f0
Compare
f14b3bb
to
bffd803
Compare
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
@asellaminxp please re-visit this PR. |
bffd803
to
61f03f8
Compare
The build issue was due to missing pinmux nodes in the https://github.com/zephyrproject-rtos/hal_nxp/blob/master/dts/nxp/nxp_imx/mimx9596cvtxn-pinctrl.dtsi file, where CC: @GhMarwen |
Hi, @asellaminxp , pinmux is not board level, it should be SoC level. as 15x15 has different pinmux with 19x19, so it should have a standalone SoC dts, as they have the same memory layout for all peripherals, so could create a common dtsi common.dtsi like to cover these common part, then in 19x19.dtsi and 15x15.dtsi will include common.dtsi and silicon specified pinmux dts nodes. |
61f03f8
to
ec6b9d7
Compare
Indeed, I created the new DTSIs for 19x19 and 15x15, as suggested. |
west.yml
Outdated
@@ -210,7 +210,7 @@ manifest: | |||
groups: | |||
- hal | |||
- name: hal_nxp | |||
revision: 111f568bda6f119cd896f38ae5843ecde92039bd | |||
revision: 49ca79a20d932374a2c26e4f47153d17c038c0b5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revision: refs/pull/553/head
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -6,7 +6,7 @@ | |||
|
|||
/dts-v1/; | |||
|
|||
#include <nxp/nxp_mimx95_a55.dtsi> | |||
#include <nxp/nxp_mimx95_19x19_a55.dtsi> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be the first commit to add dts for 15x15, then the second one will add the board. so that it will not break bisect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to refine the commit message like:
dts: nxp: imx95-ca55: add dts for SoC 15x15 variant
As, i.MX 95 19x19 and i.MX 95 15x15 have different pinmux definitions, so keep
common part in nxp_mimx95_a55.dtsi, and define separate dts file for each variant,
they include common part and pinmux definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded the commit message as suggested. Thanks
bb984cf
to
8fff0ac
Compare
looks fine for me. |
As i.MX 95 19x19 and i.MX 95 15x15 have different pinmux definitions, keep common part in nxp_mimx95_a55.dtsi, and define separate dts file for each variants. These include the common part and their respective pinmux definitions. Signed-off-by: Aziz Sellami <[email protected]>
Add initial support for i.MX 95 15x15 LPDDR4x EVK board. This board uses the i.MX 95 15x15 SoC that shares many similarities to the already supported i.MX 95 19x19 SoC used for the i.MX 95 19x19 LPDDR5 EVK. This enables Zephyr to boot and run on the i.MX 95 15x15 EVK and provides a foundation for further peripheral enablement and application development. Signed-off-by: Aziz Sellami <[email protected]>
8fff0ac
to
f522227
Compare
|
Add initial support for i.MX 95 15x15 LPDDR4x EVK board. This board uses the i.MX 95 15x15 SoC that shares many similarities to the already supported i.MX 95 19x19 SoC used for the i.MX 95 19x19 LPDDR5 EVK.
This enables Zephyr to boot and run on the i.MX 95 15x15 EVK and provides a foundation for further peripheral enablement and application development.
Depends on: