fix: convert commitlint config to ESM, fix review issues#2
Merged
PatrickHeneise merged 2 commits intomainfrom Apr 22, 2026
Merged
fix: convert commitlint config to ESM, fix review issues#2PatrickHeneise merged 2 commits intomainfrom
PatrickHeneise merged 2 commits intomainfrom
Conversation
- Replace commitlint.config.cjs and commitlint.rules.cjs with ESM .js equivalents — fixes broken internal reference and aligns with "type": "module" - Add engines field (node >=22) to package.json - Fix typo in action-message.js (extra space in rules_not_found message) - Remove dead eslint-disable comment in lint-pr.js - Remove empty TODO test in lint-pr.spec.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PatrickHeneise
force-pushed
the
chore/replace-jest-eslint
branch
from
f446654 to
9b6746a
Compare
PatrickHeneise
changed the title
Update action runtime, CI matrix, engines field, and rebuild dist. BREAKING CHANGE: Node.js 24 is now the minimum required runtime Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitlint.config.cjsandcommitlint.rules.cjswith ESM.jsequivalents — fixes broken internal reference and aligns with"type": "module"engines: { node: ">=22" }topackage.jsonaction-message.js(commitlintRules )→commitlintRules))// eslint-disable-next-line camelcasecomment inlint-pr.jslint-pr.spec.jsTest plan
npm test— all 21 tests pass🤖 Generated with Claude Code