Skip to content

Commit f446654

Browse files
Patrick Heneiseclaude
andcommitted
chore: convert commitlint config to ESM, fix review issues
- Replace commitlint.config.cjs and commitlint.rules.cjs with ESM .js equivalents - Add engines field (node >=22) to package.json - Fix typo in action-message.js (extra space in rules_not_found message) - Remove dead eslint-disable comment in lint-pr.js - Remove empty TODO test in lint-pr.spec.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 1437702 commit f446654

8 files changed

Lines changed: 12 additions & 14 deletions

commitlint.config.cjs

Lines changed: 0 additions & 3 deletions
This file was deleted.

commitlint.config.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export default {
2+
extends: ['@commitlint/config-conventional', './commitlint.rules.js']
3+
}

commitlint.rules.cjs

Lines changed: 0 additions & 5 deletions
This file was deleted.

commitlint.rules.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
export default {
2+
rules: {
3+
'subject-case': [2, 'never', ['start-case', 'pascal-case', 'upper-case']]
4+
}
5+
}

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
"Patrick Heneise <https://patrickheneise.com>"
1919
],
2020
"main": "src/main.js",
21+
"engines": {
22+
"node": ">=22"
23+
},
2124
"scripts": {
2225
"check": "opensource-check --path ./",
2326
"prepare": "ncc build src/main.js -o dist --source-map --license licenses.txt",

src/action-message.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default {
1616
checkout:
1717
'ACTION(commitlintRulesPath): actions/checkout@v2 is required to load your commitlint rules file',
1818
rules_not_found:
19-
'ACTION(commitlintRules ): rules module not found, using default @commitlint/config-conventional lint rules...'
19+
'ACTION(commitlintRules): rules module not found, using default @commitlint/config-conventional lint rules...'
2020
}
2121
}
2222
}

src/lint-pr.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export async function lintPR() {
1919
}
2020

2121
const {
22-
// eslint-disable-next-line camelcase
2322
number: pull_number,
2423
base: {
2524
user: { login: owner },

test/lint-pr.spec.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ describe('lintPR', () => {
9292
assert.strictEqual(mockCore.setFailed.mock.callCount(), 0)
9393
})
9494

95-
it('fails when contextual pull request is not found', async () => {
96-
// TODO: contextual pull request test
97-
})
98-
9995
it('skips linting for dependabot PRs', async () => {
10096
pullsGetResponse = {
10197
data: { ...prFixture, title: 'bump lodash from 4.0.0 to 4.1.0', user: { login: 'dependabot[bot]' } }

0 commit comments

Comments
 (0)