Preserve foreign key constraints on columns duplicated for backfilling #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
andrew-farries
force-pushed
the
duplication-of-fk-columns
branch
from
0398eb6 to
a548fe2
Compare
andrew-farries
force-pushed
the
change-complete-method-signature
branch
from
7c8ebc7 to
9ff1f8d
Compare
andrew-farries
force-pushed
the
duplication-of-fk-columns
branch
from
a548fe2 to
85f7aa4
Compare
exekias
approved these changes
Jan 15, 2024
andrew-farries
added a commit
that referenced
this pull request
Jan 15, 2024
Change the signature of the `Complete` method on the `Operation` interface to take a `*schema.Schema` argument like the `Start` and `Validate` methods already do. This allows for implementations of `Complete` to be aware of the entire database schema, supporting things like renaming of any temporary constraints created on columns affected the operation being completed. See #230, which depends on this PR.
This function renames a duplicated column to its original name, along with with any temporary constraints that were created on the column.
This ensures that any FK constraints on the duplicated column get renamed back to their original names.
Add a test that checks that setting a column with an FK constraint to `NOT NULL` does not remove the FK constraint.
andrew-farries
force-pushed
the
duplication-of-fk-columns
branch
from
85f7aa4 to
3903555
Compare
andrew-farries
added a commit
that referenced
this pull request
Jan 15, 2024
Preserve any foreign key constraints defined on columns when changing a column's type. Uses the `Duplicator` type added in #230 in the 'change type' operation to ensure that FK constraints are preserved when the column is duplicated for backfilling. #230 did the same thing for preserving FK constraints when a column has a `NOT NULL` constraint added. Part of #227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplicating a column for backfilling to add
NOT NULLconstraint, ensure that any foreign keys on the duplicated column are preserved.This fixes the issue where adding
NOT NULLto an FK column would drop the FK from the column.This is part of a larger class of issues where duplicated columns are not faithfully preserving all properties of the original, tracked in #227.