Change Complete method signature
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Jan 15, 2024
Make `Complete` take a `schema.Schema` so that implementations have access to the `pgroll`-observed database schema when completing a migration.
andrew-farries
force-pushed
the
change-complete-method-signature
branch
from
7c8ebc7 to
9ff1f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the signature of the
Completemethod on theOperationinterface to take a*schema.Schemaargument like theStartandValidatemethods already do.This allows for implementations of
Completeto be aware of the entire database schema, supporting things like renaming of any temporary constraints created on columns affected the operation being completed.See #230, which depends on this PR.