Use raw SQL for NULLS NOT DISTINCT indexes

This option is not representable by the `pgroll` operation.
xataio · Dec 20, 2024 · e258656 · e258656
1 parent edd1cd9
commit e258656
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/sql2pgroll/create_index.go b/pkg/sql2pgroll/create_index.go
@@ -100,6 +100,10 @@ func canConvertCreateIndexStmt(stmt *pgq.IndexStmt) bool {
 	if !stmt.GetRelation().GetInh() {
 		return false
 	}
+	// Indexes with NULLS NOT DISTINCT are not supported
+	if stmt.GetNullsNotDistinct() {
+		return false
+	}
 
 	for _, param := range stmt.GetIndexParams() {
 		if param.GetIndexElem().GetCollation() != nil {

diff --git a/pkg/sql2pgroll/create_index_test.go b/pkg/sql2pgroll/create_index_test.go
@@ -144,6 +144,8 @@ func TestUnconvertableCreateIndexStatements(t *testing.T) {
 		"CREATE INDEX idx_name ON foo (bar opclass)",
 		// Indexes created with ONLY are not supported
 		"CREATE INDEX idx_name ON ONLY foo (bar)",
+		// Indexes with NULLS NOT DISTINCT are not supported
+		"CREATE INDEX idx_foo ON foo(a) NULLS NOT DISTINCT",
 	}
 
 	for _, sql := range tests {