Fall back to raw SQL for indexes created with ONLY

xataio · Dec 20, 2024 · edd1cd9 · edd1cd9
1 parent b807bec
commit edd1cd9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/sql2pgroll/create_index.go b/pkg/sql2pgroll/create_index.go
@@ -96,6 +96,11 @@ func canConvertCreateIndexStmt(stmt *pgq.IndexStmt) bool {
 	if stmt.GetIndexIncludingParams() != nil {
 		return false
 	}
+	// Indexes created with ONLY are not supported
+	if !stmt.GetRelation().GetInh() {
+		return false
+	}
+
 	for _, param := range stmt.GetIndexParams() {
 		if param.GetIndexElem().GetCollation() != nil {
 			return false

diff --git a/pkg/sql2pgroll/create_index_test.go b/pkg/sql2pgroll/create_index_test.go
@@ -142,8 +142,8 @@ func TestUnconvertableCreateIndexStatements(t *testing.T) {
 		// opclasses with or without options are not supported
 		"CREATE INDEX idx_name ON foo (bar opclass (test = test))",
 		"CREATE INDEX idx_name ON foo (bar opclass)",
-		// TODO: Can't figure out how to detect this case
-		//"CREATE INDEX idx_name ON ONLY foo (bar)",
+		// Indexes created with ONLY are not supported
+		"CREATE INDEX idx_name ON ONLY foo (bar)",
 	}
 
 	for _, sql := range tests {