Skip to content

Update protobuf-java to 4.32.0 #4011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xerial-bot wants to merge 1 commit into from
Closed

Update protobuf-java to 4.32.0 #4011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,7 @@ lazy val benchmark =
// "com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapb.compiler.Version.scalapbVersion
// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.32.0",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating protobuf-java to a new major version (4.x) requires regenerating the Protobuf-generated source files. The existing generated files in airframe-benchmark/src/main/scala/wvlet/airframe/benchmark/http/protojava/ were created with an older protoc version (from grpc-java:1.30.2) and may not be fully compatible with the new runtime. This can lead to runtime errors or incorrect benchmark results.

Please regenerate the .java files from greeter.proto using a protoc compiler version that corresponds to protobuf-java:4.32.0 and include the updated files in this pull request.

("com.chatwork" %% "scala-ulid" % "1.0.24").cross(CrossVersion.for3Use2_13)
)
// Compile / PB.targets := Seq(
Expand Down
Loading