-
Notifications
You must be signed in to change notification settings - Fork 71
Update protobuf-java to 4.32.0 #4011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs an automated update of the protobuf-java dependency. The primary purpose is to bring the project up to date with the latest stable version of Protocol Buffers for Java, ensuring access to new features, performance improvements, and bug fixes. This is a routine maintenance update managed by Scala Steward.
Highlights
- Dependency Update: The
protobuf-javalibrary has been upgraded from version3.25.8to4.32.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates protobuf-java from version 3.25.8 to 4.32.0, which is a major version upgrade. While the gRPC library in use seems to support this new version, the Protobuf-generated Java source files included in the airframe-benchmark module have not been updated. It is crucial to regenerate these files using a protoc version compatible with the new protobuf-java runtime to ensure correctness and avoid potential runtime issues or skewed benchmark results. The existing generated files were created with a much older version.
| // For grpc-java | ||
| "io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
| "com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
| "com.google.protobuf" % "protobuf-java" % "4.32.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating protobuf-java to a new major version (4.x) requires regenerating the Protobuf-generated source files. The existing generated files in airframe-benchmark/src/main/scala/wvlet/airframe/benchmark/http/protojava/ were created with an older protoc version (from grpc-java:1.30.2) and may not be fully compatible with the new runtime. This can lead to runtime errors or incorrect benchmark results.
Please regenerate the .java files from greeter.proto using a protoc compiler version that corresponds to protobuf-java:4.32.0 and include the updated files in this pull request.
|
Superseded by #4039. |
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.8to4.32.0⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: