Skip to content

Jackson OSS Fuzz issue #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Contributor

Relates to FasterXML/jackson-core#809

This change is based on the stacktrace in that issue. I don't yet have the value that caused the failure.

@pjfanning pjfanning changed the base branch from main to java8 August 12, 2022 09:49
@wrandelshofer
Copy link
Owner

The proposed change fixes the StringIndexOutOfBoundsException - which is good, of course.
But the entire &&-expression is superfluous. I don't know why I added it.

Line 327 should just have the following code:
|| digitCount == 0

@wrandelshofer
Copy link
Owner

The proposed change does not fix the same problem in the other AbstractFloatingPointBitsFrom... classes.
We need to fix those classes too.

I think, it is best, if I close this pull request, and create a new Issue for this problem.

@wrandelshofer
Copy link
Owner

I have created issue #22
I am closing this pull request, because it provides an incomplete fix. (We must fix the problem in all AbstractFloatingPointBitsFrom... classes).

@pjfanning pjfanning deleted the jackson-fuzz-issue branch August 12, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants