Skip to content

fix for issue found by OSS Fuzz #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Aug 12, 2022

Relates to wrandelshofer/FastDoubleParser#21 and #809

There is a fuller fix scheduled in wrandelshofer/FastDoubleParser#22 - which can be copied here. This existing PR may still be worth using as a partial fix.

@wrandelshofer
Copy link

Please note that this pull request does not fix the problem in all affected classes. You need to do the same changes also in class com.fasterxml.jackson.core.io.doubleparser.AbstractFloatingPointBitsFromCharArray.

Please look at the classes in the https://github.com/wrandelshofer/FastDoubleParser repository. The main branch, from revision 69cdb361224b10ffdd009bd7aadc8c8a0dacf841 onwards, contains code that fixes this problem, and runs optimal on Java 17.

@pjfanning
Copy link
Member Author

Thanks @wrandelshofer - I have copied over your latest code into this PR. Thanks for the really fast turnaround.

@cowtowncoder
Copy link
Member

I was unable to create a reproduction from oss-fuzz test case (input is... weird). But this makes sense anyway so will merge and we'll see if the issue gets resolved.

@cowtowncoder cowtowncoder merged commit 14c23e2 into FasterXML:2.14 Aug 13, 2022
@cowtowncoder
Copy link
Member

Was able to merge 2.14 -> master; was bit messy due to package renaming but I think I got it right; all tests passing.

@cowtowncoder
Copy link
Member

Good news: oss-fuzz issue seems resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants