Foreign Blockstore Support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 79.09% 81.04% +1.94%
==========================================
Files 10 10
Lines 555 728 +173
==========================================
+ Hits 439 590 +151
- Misses 116 138 +22
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
appcypher
force-pushed
the
appcypher/foreign-block-store
branch
from
3390dd3 to
2766944
Compare
appcypher
force-pushed
the
appcypher/foreign-block-store
branch
from
83af08a to
2e6a48c
Compare
|
@appcypher and I talked this PR through live |
matheus23
added a commit
that referenced
this pull request
May 17, 2022
* Conclude public fs impl * Fix script * Remove auto-generated license * Fix gh workflow and remove unused code * Foreign Blockstore Support (#16) * Conclude public fs impl * Implement foreign block store * Fix typos and remove console logs * Add new steps for arm-based macOS * Update example. Ts, foreign blockstore, usage * Delete package-lock.json & update yarn.lock * Avoid reference equality in map keys * Remove colon from wnfs.sh shbang Co-authored-by: Philipp Krüger <[email protected]> * Merge BlockStoreLookup into BlockStore trait * Added some tests, scoped down mv to a basic_mv impl Co-authored-by: appcypher <[email protected]> * Formatted & fixed wasm Co-authored-by: Philipp Krüger <[email protected]> Co-authored-by: appcypher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following features
This PR is based on another, so you will see changes from the other PR here.
Test plan (required)
Testing the Rust core.
cargo test -p wnfs --releaseTesting the wasm bindings.
cd crates/wasmyarn playwright testDepends on
Ongoing Issues
Closing issues
Fixes #15