Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete WebAssembly Foreign WNFS Blockstore Implementation #15

Closed
expede opened this issue May 6, 2022 · 2 comments · Fixed by #16
Closed

Complete WebAssembly Foreign WNFS Blockstore Implementation #15

expede opened this issue May 6, 2022 · 2 comments · Fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@expede
Copy link
Member

expede commented May 6, 2022

No description provided.

@appcypher appcypher changed the title Complete Wasm "foreign WNFS blockstores(s)" Complete WebAssembly Foreign WNFS Blockstore Implementation May 9, 2022
@appcypher appcypher mentioned this issue May 9, 2022
3 tasks
@appcypher appcypher added the enhancement New feature or request label May 9, 2022
@appcypher
Copy link
Member

Description

Right now we have a memory-based block store that works well for testing purposes but to make the js bindgen useful, we need the generated wasm code to be able to use some imported foreign block store.

The idea is to expose foreign function interfaces that will allow the wasm side to call and use some opaque block store object passed in from JavaScript code. It has to be implemented in a way that won't result in adding wasm or js specific details to the rust core.

https://github.com/WebNativeFileSystem/rs-wnfs/blob/8e59f1f056ed3b526ce1f63e789de53fa94c11b3/crates/wasm/fs/blockstore.rs#L19-L31

@appcypher
Copy link
Member

appcypher commented May 18, 2022

Fixed by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants