HWI parity: complete Ledger registered-wallet signing - #78
Open
trevarj wants to merge 4 commits into
Open
Conversation
| .ok_or(StoreError::UnknownHash)?; | ||
| .ok_or(StoreError::UnknownMerkleRoot)?; | ||
|
|
||
| let leaf_index = tree.get_leaf_index(hash).ok_or(StoreError::UnknownHash)?; |
Member
There was a problem hiding this comment.
nice catch to finally return a proper response instead of having an error.
edouardparis
approved these changes
Jul 31, 2026
- return the protocol not-found response for optional PSBT keys - preserve request context when mapping Ledger store errors
- discover and validate default and registered policies across PSBT inputs - sign each policy sequentially and merge signatures into the original PSBT - support classic sorted multisig with retained registration HMACs
- exercise legacy, nested, and native classic multisig policies - verify retained HMAC signing through direct and CLI workflows - compare default, registered, and mixed-policy PSBTs with HWI
- describe supported default and classic multisig policies - record Ledger signtx parity coverage and limitations
trevarj
force-pushed
the
trevarj/ledger_registered_signing
branch
from
July 31, 2026 10:43
8998b35 to
0f27f45
Compare
Collaborator
Author
|
Fixed conflict and ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70.
Summary
signtxsupport for default policies and registered classic sorted multisigValidation
cargo fmt --all --checkcargo clippy --all --all-features --all-targets -- -A dead_code -D warningscargo test --verbose --no-default-featurescargo test --verbose --color always -- --nocapturecargo test --all --exclude "bhwi-e2e-*" --verbose --color always -- --nocaptureUnicodeDecodeError, and the affected cases passed individually on a fresh emulatornix run .#hwi-parity-ledger -- candidate_signtx_matches_reference -- --test-threads=1nix run .#hwi-upstream-ledger(22 passed, 6 expected skips)Compatibility
register-walletandsign-psbtbehavior is unchanged