refactor(bhwi): isolate device interpreters from common types - #79
Open
trevarj wants to merge 4 commits into
Open
refactor(bhwi): isolate device interpreters from common types#79trevarj wants to merge 4 commits into
trevarj wants to merge 4 commits into
Conversation
Member
|
Concept ACK. |
- model address display with Ledger-native requests - move command, response, error, and transmit mappings to common - skip redundant fingerprint lookup for registered policies
- keep multisig commands in protocol-native address formats - move common command and response mappings to the adapter layer - retain descriptor validation at the common boundary
- move command and descriptor shaping to the common boundary - map Jade recipients, transmits, responses, and errors externally - keep the CBOR interpreter focused on Jade-native types
- keep BitBox commands, responses, and transmits device-native - move shared command and response mappings into the common layer - preserve core and async behavior with focused adapter coverage
trevarj
force-pushed
the
trevarj/device_common_boundaries
branch
from
July 31, 2026 09:45
91f045c to
582f241
Compare
trevarj
marked this pull request as ready for review
August 4, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common::adapterscommondependencies from the Ledger, Coldcard, Jade, and BitBox interpretersLedgerDisplayAddress, allowing registered policies to start directly with the wallet-address APDUDependency
This is a draft pending #78. After it merges, this branch needs to be rebased and its detailed Ledger
StoreErrormapping preserved before final review.Validation
Passed:
cargo fmt --all --checkcargo clippy --all --all-features --all-targets -- -A dead_code -D warningscargo test --verbose --no-default-featurescargo test --verbose --color always -- --nocapturecargo test --all --exclude "bhwi-e2e-*" --verbose --color always -- --nocaptureCloses #65