-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Update deutsch.md (i18n guide) #12500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →
|
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
If we find anything later, we can just PR again, so I think we can merge this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve left a few review comments based on a tutorial translation created by trueberryless (no double ping) according to #12501.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have submitted lots of review comments, so the guide itself follows the rules of the guide.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve made some changes to this guide. I don’t know why GitHub makes the line removal suggestions empty for suggestions on lines that weren’t changed, but whatever.
Co-authored-by: randomguy-2650 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added tiny notes to this guide, after translating unit 6 of the Astro tutorial to German.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new guide looks good to me 🪂
Left some final (never say final) suggestions and then I think we are good to go 📦
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added one little comment regarding about the uppercase Eszett (ẞ), but otherwise, LGTM!
Note (you may add this note yourself): I’ve tested on some operating systems and found out, that you can press AltGr + Shift + ß (next to zero) to input the uppercase Eszett (does work on Windows, not sure if it works in Linux distros).
Co-authored-by: randomguy-2650 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little thing, but it LGTM!
i18n-guides/deutsch.md
Outdated
- VSCode → VS Code | ||
- NPM → npm | ||
- Markennamen, deren Name sich im Laufe der Zeit geändert hat, werden mit dem aktuellen Namen genannt; der frühere Name steht in Klammern (z. B. X (Twitter)). | ||
- Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol "U+00A0 NO-BREAK SPACE"](https://unicode-explorer.com/c/00A0) (` `) verwendet: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol "U+00A0 NO-BREAK SPACE"](https://unicode-explorer.com/c/00A0) (` `) verwendet: | |
- Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol „U+00A0 NO-BREAK SPACE“](https://unicode-explorer.com/c/00A0) (` `) verwendet: |
Just this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should just tell people to use the
HTML entity instead, or at least put it there as an option. CC @trueberryless thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, definitely mentioning at least or entirely replacing all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean 🪥
After this PR is merged, we can look over #12523 and merge it as well 🙌
- Markennamen, deren Name sich im Laufe der Zeit geändert hat, werden mit dem aktuellen Namen genannt; der frühere Name steht in Klammern (z. B. X (Twitter)). | ||
- Verwendung der falschen Anführungszeichen ("" statt „“) | ||
- Abkürzungen sind nicht mit non-breaking space versehen | ||
- `z. B.` → `z. B.` (Unicode-Zeichen) oder `z. B.` (HTML-Entität) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sieht gut aus! 🚀
LGTM! 🚀
Description (required)
This PR updates the German i18n guide:
Related issues & labels (optional)
N/A