Skip to content

Conversation

louisescher
Copy link
Member

Description (required)

This PR updates the German i18n guide:

  • Astro Islands should no longer be translated.
  • Component names, class names and variable names should no longer be translated in accordance to common best practices.

Related issues & labels (optional)

N/A

@louisescher louisescher added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 5, 2025
Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for astro-docs-2 failed. Why did it fail? →

Name Link
🔨 Latest commit d13ea90
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68e7b85a8552eb0007e86281

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 5, 2025
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
@louisescher louisescher marked this pull request as ready for review October 5, 2025 10:05
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

If we find anything later, we can just PR again, so I think we can merge this 👍

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve left a few review comments based on a tutorial translation created by trueberryless (no double ping) according to #12501.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have submitted lots of review comments, so the guide itself follows the rules of the guide.

louisescher and others added 16 commits October 5, 2025 16:29
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
louisescher and others added 4 commits October 5, 2025 17:23
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve made some changes to this guide. I don’t know why GitHub makes the line removal suggestions empty for suggestions on lines that weren’t changed, but whatever.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added tiny notes to this guide, after translating unit 6 of the Astro tutorial to German.

louisescher and others added 2 commits October 7, 2025 08:57
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new guide looks good to me 🪂

Left some final (never say final) suggestions and then I think we are good to go 📦

louisescher and others added 3 commits October 7, 2025 14:02
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added one little comment regarding about the uppercase Eszett (ẞ), but otherwise, LGTM!

Note (you may add this note yourself): I’ve tested on some operating systems and found out, that you can press AltGr + Shift + ß (next to zero) to input the uppercase Eszett (does work on Windows, not sure if it works in Linux distros).

Co-authored-by: randomguy-2650 <[email protected]>
Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little thing, but it LGTM!

- VSCode → VS Code
- NPM → npm
- Markennamen, deren Name sich im Laufe der Zeit geändert hat, werden mit dem aktuellen Namen genannt; der frühere Name steht in Klammern (z. B. X (Twitter)).
- Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol "U+00A0 NO-BREAK SPACE"](https://unicode-explorer.com/c/00A0) (` `) verwendet:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol "U+00A0 NO-BREAK SPACE"](https://unicode-explorer.com/c/00A0) (` `) verwendet:
- Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol U+00A0 NO-BREAK SPACE](https://unicode-explorer.com/c/00A0) (` `) verwendet:

Just this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should just tell people to use the &nbsp; HTML entity instead, or at least put it there as an option. CC @trueberryless thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, definitely mentioning at least or entirely replacing all...

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean 🪥

After this PR is merged, we can look over #12523 and merge it as well 🙌

- Markennamen, deren Name sich im Laufe der Zeit geändert hat, werden mit dem aktuellen Namen genannt; der frühere Name steht in Klammern (z. B. X (Twitter)).
- Verwendung der falschen Anführungszeichen ("" statt „“)
- Abkürzungen sind nicht mit non-breaking space versehen
- `z. B.``z. B.` (Unicode-Zeichen) oder `z.&nbsp;B.` (HTML-Entität)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😉

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus! 🚀
LGTM! 🚀

@louisescher louisescher merged commit 09c873d into main Oct 9, 2025
6 of 10 checks passed
@louisescher louisescher deleted the de-update-i18n-guide branch October 9, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants