- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.7k
          i18n(fr): update guides/upgrade-to/v5.mdx and guides/client-side-scripts.mdx
          #10687
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ✅ Deploy Preview for astro-docs-2 ready!
 To edit notification comments on pull requests, go to your Netlify site configuration. | 
| Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's  You can change this by adding one of the keywords present in the  Tracked Files
 Warnings reference
 | 
| Just a reminder that this can't merge until a) the feature is released and then also b) the English is released!! (or the page will have the wrong "translated" status. Astro Release > English docs merged > translated docs can merge | 
| Got it, will keep that in mind. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typo/nit, otherwise LGTM. Thanks!
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
| Thanks for the quick updates!, @MoustaphaDev! Maybe I should leave the  | 
| 
 Thank you for the reviews! 
 Sure, that sounds like a good plan 👍 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm correct the implementation PR has been released in withastro/compiler#1061 so I'm removing the blocking state, LGTM!
Feel free to merge this once #10656 has been merged!
| Thanks for the reminder @ArmandPhilippot, didn't see that it was released. Merging both now! | 
Description (required)
Updates
guides/upgrade-to/v5.mdxandguides/client-side-scripts.mdxto add changes from #10656.Related issues & labels (optional)