Skip to content

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Sep 2, 2025

Changes

The handling of base paths with trailingSlash never was causing an empty pattern to be generated for the root index. This PR ensures that it will always match /

Fixes #14245

Testing

Fixed a test that was missing this

Docs

Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: e4c26dc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 2, 2025
Copy link

codspeed-hq bot commented Sep 2, 2025

CodSpeed Performance Report

Merging #14302 will not alter performance

Comparing trailing-base (e4c26dc) with main (f74f063)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ascorbic!

Edit: looks like tests are failing, so take my approval with a pinch of salt 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home page doesn't work when trailingSlash is never

3 participants