chore: backport chrome fix from dev [WPB-20719] - #9198
Closed
nkaramarko wants to merge 4 commits into
Closed
Conversation
chore: update Electron to 38.2.0 for Chromium 140 (SAP SSO compatibility) [WPB-20719] (cherry picked from commit d02b886)
thisisamir98
approved these changes
Oct 30, 2025
…8 compatibility) Replaced disable-features=WebRtcHideLocalIpsWithMdns with force-webrtc-ip-handling-policy=all to maintain the same behavior (disable mDNS local IP obfuscation to prevent Windows firewall prompt) while ensuring compatibility with Electron ≥36.
Contributor
|
@z-dule @EnricoSchw could you have a look as well? |
emil-wire
approved these changes
Nov 3, 2025
EnricoSchw
requested changes
Nov 5, 2025
|
EnricoSchw
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #9128 from wireapp/fix/chrome
Jira: https://wearezeta.atlassian.net/browse/WPB-20719
Update Electron from 35.0.2 to 38.2.0
Chromium version now 140.0.7339.133 (was 134.0.6998.88)
Fixes SAP SSO authentication issue requiring Chromium 139+
Add optional chaining for app.dock to fix TypeScript strictness