Skip to content

chore: backport chrome fix from dev [WPB-20719] #9198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

chore: backport chrome fix from dev [WPB-20719] #9198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f73d01e
Merge pull request #9128 from wireapp/fix/chrome
vkuprin Oct 2, 2025
07e517e
chore: replace deprecated mDNS flag with webrtc ip policy (Electron 3…
nkaramarko Oct 31, 2025
02dc9eb
chore: remove comment
nkaramarko Nov 3, 2025
7b4d2d4
fix(electron): update WebRTC flags to modern Chromium syntax and beha…
nkaramarko Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions electron/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,11 @@ Object.entries(config).forEach(([key, value]) => {
// Squirrel setup
app.setAppUserModelId(config.appUserModelId);

// do not use mdns for local ip obfuscation to prevent windows firewall prompt
app.commandLine.appendSwitch('disable-features', 'WebRtcHideLocalIpsWithMdns');
// Disable mDNS IP masking so local/private IPs are exposed (prevents Windows firewall prompt)
app.commandLine.appendSwitch('disable-features', 'webrtc-hide-local-ips-with-mdns');

// Allow both public and private interfaces for WebRTC
app.commandLine.appendSwitch('force-webrtc-ip-handling-policy', 'default_public_and_private_interfaces');

app.getGPUInfo('basic').then((info: any) => {
const gpuDevices = 'gpuDevice' in info ? info.gpuDevice : [];
Expand Down
2 changes: 1 addition & 1 deletion electron/src/menu/TrayHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class TrayHandler {
is optional (default), but makes it easier to read
*/
if (process.platform === 'darwin') {
app.dock.bounce('informational');
app.dock?.bounce('informational');
} else {
win.flashFrame(true);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"cross-env": "7.0.3",
"css-loader": "7.1.2",
"dotenv": "16.5.0",
"electron": "35.0.2",
"electron": "38.2.0",
"electron-builder": "24.13.3",
"electron-mocha": "12.3.1",
"electron-packager": "17.1.2",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7920,16 +7920,16 @@ __metadata:
languageName: node
linkType: hard

"electron@npm:35.0.2":
version: 35.0.2
resolution: "electron@npm:35.0.2"
"electron@npm:38.2.0":
version: 38.2.0
resolution: "electron@npm:38.2.0"
dependencies:
"@electron/get": ^2.0.0
"@types/node": ^22.7.7
extract-zip: ^2.0.1
bin:
electron: cli.js
checksum: e0bd4e5299f09a860815b72ca7e4087147c762a79e3fed8f431e40f6369d244b65f554d6882f9ef379891929368a7010a062a3ca54676ab1cedb023caec9e102
checksum: 115a6e2b73a404b090c808ef67832111ddd305338aafbe6b22f8e0c58be079255b438c7ab8d9e579db5418edcba7990336ae51b6896e50b999cdbc3fa3ca573d
languageName: node
linkType: hard

Expand Down Expand Up @@ -18989,7 +18989,7 @@ __metadata:
cross-env: 7.0.3
css-loader: 7.1.2
dotenv: 16.5.0
electron: 35.0.2
electron: 38.2.0
electron-builder: 24.13.3
electron-dl: ^3.5.2
electron-mocha: 12.3.1
Expand Down
Loading