chore: backport chrome fix from dev [WPB-20719] #9198
Conversation
chore: update Electron to 38.2.0 for Chromium 140 (SAP SSO compatibility) [WPB-20719] (cherry picked from commit d02b886)
…8 compatibility) Replaced disable-features=WebRtcHideLocalIpsWithMdns with force-webrtc-ip-handling-policy=all to maintain the same behavior (disable mDNS local IP obfuscation to prevent Windows firewall prompt) while ensuring compatibility with Electron ≥36.
|
@z-dule @EnricoSchw could you have a look as well? |
|
| // do not use mdns for local ip obfuscation to prevent windows firewall prompt | ||
| app.commandLine.appendSwitch('disable-features', 'WebRtcHideLocalIpsWithMdns'); | ||
|
|
||
| app.commandLine.appendSwitch('force-webrtc-ip-handling-policy', 'all'); |
There was a problem hiding this comment.
You're making two changes at once here:
Remove deprackted MDNS (is disabled by default now)
With mdns, your internal IP address is masked. So instead of, for example, broadcasting the local IP address 10.10.10.02, it becomes something like bb5bf085-0e64-438d-8059-20be6887f0cc.local.
This is supposed to increase security, but it also causes problems. Chrome has now disabled it. Firefox still does it by default.
Change global IP gathering police to ALL
This determines which IP addresses Chrome is allowed to use:
There are three settings:
- default_public_and_private_interfaces (is default) -> allow all
- default_public_interface_only -> blocks private ip
- disable_non_proxied_udp -> blocks udp
I couldn't find the "ALL" setting anywhere. But we should leave it on the default setting, otherwise our application won't work anymore.
Merge pull request #9128 from wireapp/fix/chrome
Jira: https://wearezeta.atlassian.net/browse/WPB-20719
Update Electron from 35.0.2 to 38.2.0
Chromium version now 140.0.7339.133 (was 134.0.6998.88)
Fixes SAP SSO authentication issue requiring Chromium 139+
Add optional chaining for app.dock to fix TypeScript strictness