Add secp256k1 & brainpool EC curves #60
Conversation
|
secp256k1:
brainpoolP256r1:
|
|
Nice!
|
|
Hey @waltkb, are you planning to finalize PR based on the comment above, or could I finish it by myself? |
|
Hi, is it fine like this now? |
|
|
||
| generateDigests { digest, _ -> | ||
| if (!supportsDigest(digest)) return@generateDigests | ||
| if (!supportsDigest(digest)) { | ||
| println("Skipping digest $digest for curve ${curve.name}") |
There was a problem hiding this comment.
Could you please remove all such println?
It's possible to enable more logging for supports* and executes algorithms via flipping enabled flag here
In case you think that the logging is necessary, please use logger.log, as there could be problems with excessive logging on CI if enabled :(
| assertEquals( | ||
| rawSignatureSize, | ||
| sigEmpty.size, | ||
| "RAW signature size mismatch for empty data on ${curve.name} / ${digest.name}" |
| @@ -87,27 +149,41 @@ abstract class EcdsaTest(provider: CryptographyProvider) : AlgorithmTest<ECDSA>( | |||
|
|
|||
| @Test | |||
| fun testFunctions() = testWithAlgorithm { | |||
| if (!supportsFunctions()) return@testWithAlgorithm | |||
| if (!supportsFunctions()) { | |||
| println("Skipping function test because functions are not supported by provider") | |||
There was a problem hiding this comment.
same here about println (in whole file)
| @@ -24,40 +24,94 @@ abstract class EcdsaTest(provider: CryptographyProvider) : AlgorithmTest<ECDSA>( | |||
| data class EcdsaSize( | |||
| val curve: EC.Curve, | |||
| val rawSignatureSize: Int, | |||
| val derSignatureSizes: List<Int>, | |||
| val derSignatureSizes: IntRange, | |||
|
Hi there! Thanks for the work on adding the BP curves. I made a patch replacing the println statements. As the merge request has conflicts I also performed a rebase against main. I can issue a merge request against the walt repo if that helps. |
|
Merged via #78 |
No description provided.