Add secp256k1 & brainpool EC curves #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyoleg
requested changes
Feb 19, 2025
|
secp256k1:
brainpoolP256r1:
|
|
Nice!
|
|
Hey @waltkb, are you planning to finalize PR based on the comment above, or could I finish it by myself? |
|
Hi, is it fine like this now? |
whyoleg
requested changes
Apr 24, 2025
|
|
||
| generateDigests { digest, _ -> | ||
| if (!supportsDigest(digest)) return@generateDigests | ||
| if (!supportsDigest(digest)) { | ||
| println("Skipping digest $digest for curve ${curve.name}") |
There was a problem hiding this comment.
Could you please remove all such println?
It's possible to enable more logging for supports* and executes algorithms via flipping enabled flag here
In case you think that the logging is necessary, please use logger.log, as there could be problems with excessive logging on CI if enabled :(
| assertEquals( | ||
| rawSignatureSize, | ||
| sigEmpty.size, | ||
| "RAW signature size mismatch for empty data on ${curve.name} / ${digest.name}" |
| @@ -87,27 +149,41 @@ abstract class EcdsaTest(provider: CryptographyProvider) : AlgorithmTest<ECDSA>( | |||
|
|
|||
| @Test | |||
| fun testFunctions() = testWithAlgorithm { | |||
| if (!supportsFunctions()) return@testWithAlgorithm | |||
| if (!supportsFunctions()) { | |||
| println("Skipping function test because functions are not supported by provider") | |||
There was a problem hiding this comment.
save here about println (in whole file)
| @@ -24,40 +24,94 @@ abstract class EcdsaTest(provider: CryptographyProvider) : AlgorithmTest<ECDSA>( | |||
| data class EcdsaSize( | |||
| val curve: EC.Curve, | |||
| val rawSignatureSize: Int, | |||
| val derSignatureSizes: List<Int>, | |||
| val derSignatureSizes: IntRange, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.