-
Notifications
You must be signed in to change notification settings - Fork 25
Add Ed (edwards curve), EdDSA (Ed25519/Ed448) and XDH (X25519/X448) interfaces #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…and XDH (X25519/X448) interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This would be a lovely addition to the library!
While I'm investigating a bit regarding the naming for the algorithms and curves, could you try to implement those algorithms in openssl and webcrypto providers?
As far as I see, web crypto recently added support for them (f.e. in deriveBits), so it's better to recheck if it's supported in latest browsers/nodejs
As for openssl - I'm pretty sure it's supported for some time
cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkEd.kt
Outdated
Show resolved
Hide resolved
cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkEdDSA.kt
Outdated
Show resolved
Hide resolved
cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkXDH.kt
Outdated
Show resolved
Hide resolved
Hey @waltkb, do you mind finalizing implementation for other providers or could I finish it by myself? |
I found out that Ed25519 should actually work not just in NodeJs, but also in Firefox (Desktop and Android) and Safari (Desktop and iOS) on the Web (only Chrome is still lacking behind, where However, while OpenSSL3 definitely supports it, I don't really know enough about cinterop and the OpenSSL API to implement this. Would it be fine if I only implemented it for JDK and JS for now? |
Yeah, sure. I will implement those before merging the PR to validate that all of the implementation are compatible |
I've done a bit of research and I think that we should make So I would suggest to having If you need any more help, please feel free to ping me. |
#60 is already included in this branch.