Remove the byline component #2601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrahimMahadi
force-pushed
the
minister-and-byline
branch
from
b805858 to
587f310
Compare
duboisp
previously requested changes
Jul 11, 2025
Member
duboisp
left a comment
duboisp
left a comment
There was a problem hiding this comment.
The byline need to be removed, not transformed.
Let's get that prepare for our next major version.
BrahimMahadi
changed the title
BrahimMahadi
force-pushed
the
minister-and-byline
branch
from
587f310 to
a8558d3
Compare
Collaborator
|
Pre-approved upon successful review. |
Garneauma
requested changes
Jul 17, 2025
Collaborator
Garneauma
left a comment
Garneauma
left a comment
There was a problem hiding this comment.
Minor change. The rest seems good.
BrahimMahadi
force-pushed
the
minister-and-byline
branch
from
25400fa to
066af05
Compare
Garneauma
previously approved these changes
Jul 21, 2025
Collaborator
|
@BeraJosh For your approval. This is only content change. |
BrahimMahadi
force-pushed
the
minister-and-byline
branch
from
afa658d to
40aa582
Compare
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
Garneauma
approved these changes
Nov 28, 2025
Collaborator
|
API changes: Minor - Step by step navigation: changed context of use to be used right after main title instead of after the byline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecated byline from pages. References JIRA ticket] WET-518