Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put search UI at top of editor #428

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Put search UI at top of editor #428

merged 1 commit into from
Jun 19, 2024

Conversation

greggman
Copy link
Collaborator

@greggman greggman commented Jun 18, 2024

Also, make max editor size to be 100vh

Hopefully that provides a better UX as it
keeps the search area on the screen.

It's not perfect because until the search UI hits the top of the screen it keeps moving so you have to chase it with your mouse. Putting at the bottom doesn't work because it's off the screen by default.

I spent a few minutes trying to make it hover at the bottom but failed.

Ultimately I'm mixed on the point. The code is on github. We could just have a link to the correct folder on github.

Also, make max editor size to be 100vh

Hopefully that provides a better UX as it
keeps the search area on the screen.
@greggman
Copy link
Collaborator Author

before: Clicking in text area and pressing Ctrl-F/Cmd-F does nothing (because the search is at the bottom of the page). Even going to the bottom of the page, typing in "device" and picking "next" doesn't appear to do anyting.

Screen.Recording.2024-06-18.at.10.01.47.mp4

after: clicking in text area and pressing Ctrl-F/Cmd-F the search UI appears at the top. The text area is limited to 100vh so once it fill the screen you're scrolling through the editor, not the page. Typing "device" and pressing "next" takes you do each result.

Screen.Recording.2024-06-18.at.10.03.42.mp4

@greggman greggman merged commit 6498760 into webgpu:main Jun 19, 2024
1 check passed
@greggman greggman deleted the search branch June 19, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants