Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "find" functionality is broken on desktop. Makes it hard to navigate the code. #426

Closed
Tomycj opened this issue Jun 16, 2024 · 4 comments

Comments

@Tomycj
Copy link

Tomycj commented Jun 16, 2024

The find function (Ctrl+F) doesn't work properly in the section that shows the code in the webgpu samples, at least on Chrome for desktop. For some reason it often doesn't find all matches within the code). The same section has its own search function, but it sticks to the bottom, which makes it almost useless since it gets out of reach once it jumps to a match that's out of view.

@greggman
Copy link
Collaborator

Can you post a video of the issue?

This is what I see on my Mac

Screen.Recording.2024-06-16.at.17.54.05.mp4

(ps: used handbreak to take it from 38meg to 3meg)

@Tomycj
Copy link
Author

Tomycj commented Jun 18, 2024

Thank you for the detailed reply!

Notice how the browser's find function was unable to find all matches (it misses "device" on line 216). It seems to only be able to find those that are roughly visible on screen, so it works a little better for words with a lot of matches since switching between them reveals new text to find new matches on.

2024-06-17.22-49-16.mp4

The behavior on my end is the same, except I can't (or don't know how to) automatically move between matches without having to go back down to the finder controls. That capability (or the controls staying fixed on the screen, like the browser's) would make it much more comfortable to browse the code. Btw, how do you manage to view the page in dark colors?

Thank you.

@greggman
Copy link
Collaborator

Btw, how do you manage to view the page in dark colors?

For me, I go into my OS and set it to dark mode

Or you can set your browser to dark mode separate from your OS

@greggman
Copy link
Collaborator

#428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants