Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make external links work #378

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

greggman
Copy link
Collaborator

@greggman greggman commented Mar 7, 2024

This is a work in progress so no review needed yet. Though of course feedback welcome. Of course a different category would be good. I just wanted to see it work so stuck it in. I can add the rest if we've decided to go forward with this.

It's not clear to me if linking to external examples a good thing or not. I think Brandon's examples are great but I once you set the example of linking to external examples then everyone will want their sample included. Maybe that's a good thing though?

#362

src/main.ts Show resolved Hide resolved
Adds @toji's examples

Also makes `description` to be markdown. I considered HTML
but I think markdown is easier to review and less likely
to encourage anything more than **bold** `code`, and links
and showdown, the markdown library, didn't have lots of
dependencies.
@greggman greggman force-pushed the external-examples branch from 5bd50d0 to 7541482 Compare March 8, 2024 06:03
@greggman
Copy link
Collaborator Author

greggman commented Mar 8, 2024

okay, updated with all 5 examples. Please review.

greggman referenced this pull request Mar 8, 2024
This sample has been languishing in a branch for a while because
react's handling of asset files prevented it from working correctly.
Now that react has been removed from the sample pages, though, it
works as expected! Thanks @greggman!
Copy link
Contributor

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits. And while I certainly don't mind having some of my samples linked here I do think it would be a good idea to find some from other authors if we're going to start linking to external sources like this.

sample/metaballs/meta.ts Outdated Show resolved Hide resolved
sample/pristineGrid/meta.ts Outdated Show resolved Hide resolved
@greggman greggman enabled auto-merge (squash) March 8, 2024 20:05
@greggman greggman merged commit 1d2cc4d into webgpu:main Mar 8, 2024
1 check passed
@greggman greggman deleted the external-examples branch March 8, 2024 20:42
@greggman
Copy link
Collaborator Author

greggman commented Mar 8, 2024

I agree. I was trying to think of some but I don't know any off the top of my head

I could put a few from webgpufundamentals but I could just copy them here. One that comes to mind is the multiple canvas example. It could use better models on the sample site whereas on the fundamentals site I wanted to keep it simple.

https://webgpufundamentals.org/webgpu/webgpu-multiple-canvases-x200-optimized.html

Another is points but again, can just copy it

https://webgpufundamentals.org/webgpu/webgpu-points-w-size.html

And maybe give it some GUI options for the rest

https://webgpufundamentals.org/webgpu/webgpu-points-w-rotation.html

https://webgpufundamentals.org/webgpu/webgpu-points-3d.html

https://webgpufundamentals.org/webgpu/webgpu-points-3d-fixed-size.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants