-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions to categories on hover #360
Merged
Merged
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d51dc45
Merge pull request #1 from webgpu/main
cmhhelgeson 766427d
Merge pull request #2 from webgpu/main
cmhhelgeson 415bd67
Merge pull request #3 from webgpu/main
cmhhelgeson ff38128
Merge pull request #4 from webgpu/main
cmhhelgeson c4f73a1
Merge branch 'main' of https://github.com/cmhhelgeson/webgpu-samples
cmhhelgeson c5a9982
Merge pull request #5 from webgpu/main
cmhhelgeson 08d811d
Merge branch 'main' of https://github.com/cmhhelgeson/webgpu-samples
cmhhelgeson 1db2e10
Merge branch 'webgpu:main' into main
cmhhelgeson ebbb389
Encapsulated sample page link logic into its own component, which wil…
cmhhelgeson 73f26d7
Test
cmhhelgeson 5419898
New sidebar layout
cmhhelgeson 970f069
First draft
cmhhelgeson 12e1770
Sketch dropdown before merging main into this branch
cmhhelgeson 8bfa289
Merge branch 'webgpu:main' into main
cmhhelgeson 1879c54
merge main into sample_organize_branch
cmhhelgeson f3c618c
Dropdowns complete. Note that dropdowns can easily be removed if they…
cmhhelgeson bc57254
fix build errors
cmhhelgeson 8a980a8
Implemented most suggested changes, will have further discussions abo…
cmhhelgeson 95334d3
Moved stuffed around, added comments justifying each category
cmhhelgeson f05a846
Capitalize GPGPU
cmhhelgeson 40ee507
Added more specific comments to gpgpu section
cmhhelgeson 14c55f8
Cambios pequenos
cmhhelgeson 4f03134
Add descriptions to categories
cmhhelgeson e264cb3
Merge branch 'main' into sample_organize_branch
cmhhelgeson be6a20f
Merge branch 'webgpu:main' into main
cmhhelgeson ee7f89f
Merge branch 'main' into sample_organize_branch
cmhhelgeson f09bb8e
Fixed build errors
cmhhelgeson c56edee
fixed error
cmhhelgeson c7aad95
Fix
cmhhelgeson b8f35fc
Fixes
cmhhelgeson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,8 @@ a:hover { | |
} | ||
|
||
h3 { | ||
margin-bottom: 5px; | ||
margin-top: 5px; | ||
margin-bottom: 0px; | ||
margin-top: 0px; | ||
} | ||
|
||
main { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this description it's not really clear reversedZ and samplerParameters should belong in this category.
Maybe samplerParameters should just move into Basic Graphics instead of trying to come up with a reason it should be here, and this description should be "Highlights of important WebGPU features" or "Highlights of important WebGPU graphics features"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed