-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions to categories on hover #360
Conversation
Test Merge
Merge main into my fork
Merge Main
Merge main into my fork.
Merge branches
…l be necessary to prevent duplication of the sample initialization code for each sub category of samples
… are deemed unecessary for the functionality of this webpage
…ut categorization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/pages/samples/[slug].tsx
Outdated
createPageCategory( | ||
'WebGPU Features', | ||
webGPUFeaturesPages, | ||
'Demos of WebGPU-specific features or WebGPU-specific implementations of features.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this description it's not really clear reversedZ and samplerParameters should belong in this category.
- reversedZ exists in all the APIs, we're just highlighting that it's available in core WebGPU.
- samplerParameters is really just an interactive way of understanding how sampler parameters work. It uses WebGPU's naming, but these features have been around basically forever, so it has very little to do with WebGPU specifically.
Maybe samplerParameters should just move into Basic Graphics instead of trying to come up with a reason it should be here, and this description should be "Highlights of important WebGPU features" or "Highlights of important WebGPU graphics features"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
More changes overall. We should finish this PR and land it first though since you already have it. |
How long do you think that will be? |
@greggman would have to answer that |
I am working on #355. Hopefully I'll have something to review today or tomorrow |
WebGPU.Samples.-.Google.Chrome.2024-02-29.14-40-30.mp4