Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to categories on hover #360

Merged
merged 30 commits into from
Mar 4, 2024

Conversation

cmhhelgeson
Copy link
Contributor

  1. Fix overflow bug in panel element
  2. Add brief descriptions of sample categories on hover
WebGPU.Samples.-.Google.Chrome.2024-02-29.14-40-30.mp4

Merge main into my fork
Merge main into my fork.
…l be necessary to prevent duplication of the sample initialization code for each sub category of samples
… are deemed unecessary for the functionality of this webpage
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we are planning to do #355 in some way and I think @greggman has started looking at it. We might want to hold off on more changes after this PR until that's done.

createPageCategory(
'WebGPU Features',
webGPUFeaturesPages,
'Demos of WebGPU-specific features or WebGPU-specific implementations of features.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this description it's not really clear reversedZ and samplerParameters should belong in this category.

  • reversedZ exists in all the APIs, we're just highlighting that it's available in core WebGPU.
  • samplerParameters is really just an interactive way of understanding how sampler parameters work. It uses WebGPU's naming, but these features have been around basically forever, so it has very little to do with WebGPU specifically.

Maybe samplerParameters should just move into Basic Graphics instead of trying to come up with a reason it should be here, and this description should be "Highlights of important WebGPU features" or "Highlights of important WebGPU graphics features"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@cmhhelgeson
Copy link
Contributor Author

FYI we are planning to do #355 in some way and I think @greggman has started looking at it. We might want to hold off on more changes after this PR until that's done.

More changes to this branch specifically, or more changes overall?

@kainino0x
Copy link
Collaborator

More changes to this branch specifically, or more changes overall?

More changes overall. We should finish this PR and land it first though since you already have it.

@cmhhelgeson
Copy link
Contributor Author

More changes to this branch specifically, or more changes overall?

More changes overall. We should finish this PR and land it first though since you already have it.

How long do you think that will be?

@kainino0x kainino0x merged commit 5f11215 into webgpu:main Mar 4, 2024
1 check passed
@cmhhelgeson cmhhelgeson deleted the sample_organize_branch branch March 4, 2024 19:45
@kainino0x
Copy link
Collaborator

How long do you think that will be?

@greggman would have to answer that

@greggman
Copy link
Collaborator

greggman commented Mar 4, 2024

I am working on #355. Hopefully I'll have something to review today or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants