Update perf display style #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kainino0x Please review. cc @toji |
greggman
approved these changes
Nov 22, 2023
toji
approved these changes
Nov 22, 2023
greggman
added a commit
to greggman/webgpu-samples
that referenced
this pull request
Nov 22, 2023
I was surprised to learn that this didn't default to z-Index > 0. I think it works in most apps because it's expected not to call the GUI constructor until after your other elements have been created? (I didn't look too deeply) It's possible you might want to move elements, see webgpu#330 But in any case, it seemed like a good default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the perf display to the bottom left (instead of top left) so that controls can be accessed on mobile devices. It also updates style to make it look nicer (to my eyes at least).
old vs. new
