Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GUI appear on top of other elements #331

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

greggman
Copy link
Collaborator

I was surprised to learn that this didn't default
to z-Index > 0. I think it works in most apps because it's expected not to call the GUI constructor until after your other elements have been created? (I didn't look too deeply)

It's possible you might want to move elements, see #330

But in any case, it seemed like a good default.

Before:

I was surprised to learn that this didn't default
to z-Index > 0. I think it works in most apps because
it's expected not to call the GUI constructor until after
your other elements have been created? (I didn't look
too deeply)

It's possible you might want to move elements, see
webgpu#330
But in any case, it seemed like a good default.
@greggman greggman requested a review from toji November 22, 2023 18:05
Copy link
Contributor

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@toji toji merged commit 6682d94 into webgpu:main Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants