Add lightning transport #1264
Merged
Add lightning transport #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lightning transport Fixes #1261
Fix missing comma
agl
approved these changes
Jul 25, 2019
akshayku
approved these changes
Jul 31, 2019
selfissued
approved these changes
Jul 31, 2019
jcjones
requested changes
Jul 31, 2019
There was a problem hiding this comment.
Per https://heycam.github.io/webidl/#idl-enums , Example 33, providing "lightning" to a browser that doesn't have that part of the enum will throw a TypeError.
Perhaps we want to keep the enum as a definition, but change the structur1268es that specify it to instead ask for a String-ish type that can be carefully cast to an enum, rather than letting the WebIDL parser throw.
see issue #1268
WebAuthnBot
pushed a commit
that referenced
this pull request
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lightning transport
Fixes #1261
Preview | Diff